Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Docs | Invalid icon for twitter in the Footer of the CLI Docs #2885

Closed
arjunumenon opened this issue Dec 20, 2021 · 2 comments
Closed

Comments

@arjunumenon
Copy link
Member

arjunumenon commented Dec 20, 2021

Description

The icon provided is wrong for Github in the CLI Docs. It is taking us to the Twitter handle. We need to have a twitter icon added and modify the current Github icon URL

Steps to reproduce

  • Open CLI Docs
  • Check the Footer Navigation
  • Click GitHub icon
  • Twitter handle of PnP is opened

Expected results

GitHub repo of CLI for Microsoft 365 should be opened when you Click Github icon.

Add a new icon for Twitter which will open the twitter handle of CLI for Microsoft 365

Actual results

When you click Github icon, https://twitter.com/m365pnp gets opened up

Diagnostics

N/A

CLI for Microsoft 365 version

N/A

nodejs version

N/A

Operating system (environment)

Other

Shell

Other

cli doctor

N/A

Additional Info

N/A

@arjunumenon
Copy link
Member Author

@pnp/cli-for-microsoft-365-maintainers - I am assuming we can update the link in the Footer to be pointed to CLI GitHub Repo. Can you let me know on that please.

@appieschot
Copy link
Member

@arjunumenon while checking where it was going wrong I figured I could quickly fix it as well; added the correct Twitter icon and added a github URL so we now have both.

@waldekmastykarz waldekmastykarz added this to the v4.3 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants