Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Search->External Connection->Add doc references wrong application #2936

Closed
kevmcdonk opened this issue Jan 15, 2022 · 2 comments
Closed
Assignees
Milestone

Comments

@kevmcdonk
Copy link
Contributor

Description

On the Add External Connection for Search page, it references a Test application but the sample below talks about "My Application". Small tweak but would be nice to be consistent.

Steps to reproduce

View doc at https://pnp.github.io/cli-microsoft365/cmd/search/externalconnection/externalconnection-add/#examples

Expected results

Should reference My Application

Actual results

References test application

Diagnostics

No response

CLI for Microsoft 365 version

Web

nodejs version

Web

Operating system (environment)

Other

Shell

Other

cli doctor

No response

Additional Info

No response

@kevmcdonk
Copy link
Contributor Author

I'll pick this one up. Promise it's not just to get a badge!

@garrytrinder
Copy link
Member

Thank you @kevmcdonk its all yours!

kevmcdonk added a commit to GreyHatBeard/cli-microsoft365 that referenced this issue Jan 25, 2022
kevmcdonk added a commit to GreyHatBeard/cli-microsoft365 that referenced this issue Jan 25, 2022
@waldekmastykarz waldekmastykarz added this to the v5 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants