Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spo hubsite disconnect to spo site hubsite disconnect #3878

Closed
milanholemans opened this issue Oct 22, 2022 · 2 comments
Closed

Rename spo hubsite disconnect to spo site hubsite disconnect #3878

milanholemans opened this issue Oct 22, 2022 · 2 comments
Assignees
Labels
breaking change hacktoberfest Issue perfect for hacktoberfest
Milestone

Comments

@milanholemans
Copy link
Contributor

We should rename the spo hubsite disconnect command to spo site hubsite disconnect.

More context: #3760 (comment)

@milanholemans milanholemans added this to the v6 milestone Oct 22, 2022
@milanholemans milanholemans self-assigned this Oct 22, 2022
@pratik2315
Copy link

Hey there @milanholemans !
I am new to the ms cli community and wanted to work on this issue as a part of hacktoberfest and work with this community beyond the fest. I am still in learning phase of typescript and ms cli (development), do you think issue is suited to a beginner?

If it is, can you please guide me a bit about it?

@milanholemans
Copy link
Contributor Author

Hi @pratik2315

Thank you for your enthusiasm! We are always happy to welcome new contributors.
However this is an issue we need merged ASAP since our v6 release is right around the corner. Also this issue is blocking another issue at the moment, that's why I assigned it to myself so we can fix it right away.

If you want to contribute, I suggest that you check our issue list, there are plenty of issues left. Check for the help wanted label and the good first issue label. These issues are suited for beginners.

Hope to see your first PR soon! 😊

milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Oct 22, 2022
@plamber plamber closed this as completed Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change hacktoberfest Issue perfect for hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants