Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use -f, --force instead of --confirm #4551

Closed
3 tasks done
waldekmastykarz opened this issue Feb 20, 2023 · 1 comment
Closed
3 tasks done

Enhancement: Use -f, --force instead of --confirm #4551

waldekmastykarz opened this issue Feb 20, 2023 · 1 comment
Assignees
@waldekmastykarz
Labels
breaking change enhancement ux UX-related work
Milestone
v7

Comments

@waldekmastykarz
Copy link
Member

waldekmastykarz commented Feb 20, 2023 •
edited

To align with other CLIs, like npm or gh, we should use -f, --force instead of --confirm. This is a breaking change for which we need to:

  • remove existing -f shorts
  • replace all instances of --confirm with -f, --force in code
  • replace all instances of --confirm with -f, --force in docs
@waldekmastykarz waldekmastykarz added this to the v7 milestone Feb 20, 2023
@martinlingstuyl
Copy link
Contributor

Opening this up as we are releasing v7 after the summer holidays. Warmly recommended for your contribution. 🎉
Target the v7 branch when raising a PR.

@waldekmastykarz waldekmastykarz self-assigned this Jul 1, 2023
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jul 1, 2023
@waldekmastykarz
Renames confirm to force. Closes pnp#4551
70d71da
@waldekmastykarz waldekmastykarz mentioned this issue Jul 1, 2023
Closed
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jul 2, 2023
@waldekmastykarz
Renames confirm to force. Closes pnp#4551
d943826
@waldekmastykarz waldekmastykarz linked a pull request Jul 2, 2023 that will close this issue
Renames confirm to force. Closes #4551 #5187
Closed
martinlingstuyl pushed a commit that referenced this issue Jul 6, 2023
@waldekmastykarz @martinlingstuyl
Renames confirm to force. Closes #4551
90ef876
martinlingstuyl pushed a commit that referenced this issue Jul 6, 2023
@waldekmastykarz @martinlingstuyl
Renames confirm to force. Closes #4551
466d0dd
plamber pushed a commit that referenced this issue Jul 9, 2023
@waldekmastykarz @plamber
Renames confirm to force. Closes #4551
a6e1280
Adam-it pushed a commit that referenced this issue Jul 9, 2023
@waldekmastykarz @Adam-it
Renames confirm to force. Closes #4551
63ff53f
milanholemans pushed a commit that referenced this issue Jul 21, 2023
@waldekmastykarz @milanholemans
Renames confirm to force. Closes #4551
669cf8c
milanholemans pushed a commit that referenced this issue Jul 21, 2023
@waldekmastykarz @milanholemans
Renames confirm to force. Closes #4551
8dfbe64
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Jul 24, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
1815cc3
milanholemans pushed a commit that referenced this issue Jul 24, 2023
@waldekmastykarz @milanholemans
Renames confirm to force. Closes #4551
178fa64
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Aug 3, 2023
@waldekmastykarz
Renames confirm to force. Closes pnp#4551
c362738
milanholemans pushed a commit that referenced this issue Aug 6, 2023
@waldekmastykarz @milanholemans
Renames confirm to force. Closes #4551
ecc9713
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 9, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
932bf7b
waldekmastykarz added a commit that referenced this issue Aug 12, 2023
@waldekmastykarz
Renames confirm to force. Closes #4551
35c9312
milanholemans pushed a commit that referenced this issue Aug 12, 2023
@waldekmastykarz @milanholemans
Renames confirm to force. Closes #4551
7e5518e
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 14, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
2621e03
Adam-it pushed a commit that referenced this issue Aug 16, 2023
@waldekmastykarz @Adam-it
Renames confirm to force. Closes #4551
b78fa98
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 16, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
26498fe
waldekmastykarz added a commit that referenced this issue Aug 19, 2023
@waldekmastykarz
Renames confirm to force. Closes #4551
1310b48
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 21, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
5740408
waldekmastykarz added a commit that referenced this issue Aug 26, 2023
@waldekmastykarz
Renames confirm to force. Closes #4551
561dd0c
Jwaegebaert pushed a commit that referenced this issue Aug 26, 2023
@waldekmastykarz @Jwaegebaert
Renames confirm to force. Closes #4551
f69d13d
Saurabh7019 pushed a commit to Saurabh7019/cli-microsoft365 that referenced this issue Sep 5, 2023
@waldekmastykarz @Saurabh7019
Renames confirm to force. Closes pnp#4551
6ac1b71
@Jwaegebaert Jwaegebaert mentioned this issue Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waldekmastykarz waldekmastykarz

Labels
breaking change enhancement ux UX-related work
Projects
None yet
Milestone
v7
Development

Successfully merging a pull request may close this issue.

Renames confirm to force. Closes #4551 waldekmastykarz/cli-microsoft365
2 participants
@martinlingstuyl @waldekmastykarz