Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated 'folder' option #4803

Closed
martinlingstuyl opened this issue Apr 26, 2023 · 8 comments
Closed

Remove deprecated 'folder' option #4803

martinlingstuyl opened this issue Apr 26, 2023 · 8 comments
Assignees
@nanddeepn
Labels
breaking change enhancement
Milestone
v7

Comments

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Apr 26, 2023 •
edited

spo file list has an option that is named --folder, while spo folder list has an option that is named --parentFolderUrl

We're deprecating --folder in favour of --folderUrl to align with our naming convention.

For v7 we'll want to remove the deprecated --folder. This ticket is for doing that!
@martinlingstuyl martinlingstuyl mentioned this issue Apr 26, 2023
Closed
@martinlingstuyl martinlingstuyl added this to the v7 milestone Apr 26, 2023
@martinlingstuyl
Copy link
Contributor Author

Opening this up as we are releasing v7 after the summer holidays. Warmly recommended for your contribution. 🎉
Target the v7 branch when raising a PR.

@nanddeepn
Copy link
Contributor

Can I work on this?

@nanddeepn
Copy link
Contributor

Hi @martinlingstuyl
May be I am missing something, but I cannot see the v7 branch to raise PR. Can you please guide?

@martinlingstuyl
Copy link
Contributor Author

Hi @nanddeepn, that's correct. @waldekmastykarz was going to make it, and you were super fast picking this up 😂

@martinlingstuyl
Copy link
Contributor Author

So let's just wait a bit. I'll ping you once it's created...

@nanddeepn
Copy link
Contributor

nanddeepn commented Jul 1, 2023 •
edited

Thank you @martinlingstuyl
I will wait for v7 branch. The heavy rains here made me raise the PR fast, as cannot go outside 😂

@martinlingstuyl
Copy link
Contributor Author

It's been created @nanddeepn

@nanddeepn nanddeepn mentioned this issue Jul 2, 2023
Closed
plamber pushed a commit that referenced this issue Jul 22, 2023
@nanddeepn @plamber
removes option 'folder' in 'spo folder list'. Closes #4803
bae8f7d
@plamber
Copy link
Contributor

plamber commented Jul 22, 2023

Merged in v7

@plamber plamber closed this as completed Jul 22, 2023
milanholemans pushed a commit that referenced this issue Jul 24, 2023
@nanddeepn @milanholemans
removes option 'folder' in 'spo folder list'. Closes #4803
a19d535
milanholemans pushed a commit that referenced this issue Aug 6, 2023
@nanddeepn @milanholemans
removes option 'folder' in 'spo folder list'. Closes #4803
bf81502
waldekmastykarz pushed a commit that referenced this issue Aug 12, 2023
@nanddeepn @waldekmastykarz
removes option 'folder' in 'spo folder list'. Closes #4803
c41a286
milanholemans pushed a commit that referenced this issue Aug 12, 2023
@nanddeepn @milanholemans
removes option 'folder' in 'spo folder list'. Closes #4803
438f84e
Adam-it pushed a commit that referenced this issue Aug 16, 2023
@nanddeepn @Adam-it
removes option 'folder' in 'spo folder list'. Closes #4803
86c5683
waldekmastykarz pushed a commit that referenced this issue Aug 19, 2023
@nanddeepn @waldekmastykarz
removes option 'folder' in 'spo folder list'. Closes #4803
cd67bbf
waldekmastykarz pushed a commit that referenced this issue Aug 26, 2023
@nanddeepn @waldekmastykarz
removes option 'folder' in 'spo folder list'. Closes #4803
cf0188c
Jwaegebaert pushed a commit that referenced this issue Aug 26, 2023
@nanddeepn @Jwaegebaert
removes option 'folder' in 'spo folder list'. Closes #4803
9cea11f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanddeepn nanddeepn

Labels
breaking change enhancement
Projects
None yet
Milestone
v7
Development

No branches or pull requests
4 participants
@martinlingstuyl @nanddeepn @plamber @Jwaegebaert