Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: Spinner is visible in verbose logs #5378

Closed
milanholemans opened this issue Aug 7, 2023 · 0 comments
Closed

Bug report: Spinner is visible in verbose logs #5378

milanholemans opened this issue Aug 7, 2023 · 0 comments
Assignees
@milanholemans
Labels
bug work in progress
Milestone
v7

Comments

@milanholemans
Copy link
Contributor

Priority

(Low) Something is a little off

Description

For our v7 version of CLI, I noticed that our spinner is visible in verbose/debug logs. This issue doesn't occur in the current stable version.

image

Steps to reproduce

Run any command (with verbose logs) with the --verbose flag.

Expected results

Clean verbose messages.

Actual results

Spinner is printed in the logs.

Diagnostics

No response

CLI for Microsoft 365 version

v7.0.0

nodejs version

v18.16.0

Operating system (environment)

Windows

Shell

PowerShell

cli doctor

No response

Additional Info

No response
@milanholemans milanholemans added this to the v7 milestone Aug 7, 2023
@milanholemans milanholemans self-assigned this Aug 8, 2023
milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Aug 8, 2023
@milanholemans
Fixes spinner when logging verbose messages. Closes pnp#5378
d64c7ea
milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Aug 8, 2023
@milanholemans
Fixes spinner when logging verbose messages. Closes pnp#5378
d66f547
@milanholemans milanholemans mentioned this issue Aug 8, 2023
Closed
@milanholemans milanholemans linked a pull request Aug 8, 2023 that will close this issue
Fixes spinner when logging verbose messages #5383
Closed
milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Aug 12, 2023
@milanholemans
Fixes spinner when logging verbose messages. Closes pnp#5378
863727d
milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Aug 12, 2023
@milanholemans
Fixes spinner when logging verbose messages. Closes pnp#5378
4f39cf8
waldekmastykarz pushed a commit that referenced this issue Aug 13, 2023
@milanholemans @waldekmastykarz
Fixes spinner when logging verbose messages. Closes #5378
4eb45f9
Adam-it pushed a commit that referenced this issue Aug 16, 2023
@milanholemans @Adam-it
Fixes spinner when logging verbose messages. Closes #5378
5e50e27
waldekmastykarz pushed a commit that referenced this issue Aug 19, 2023
@milanholemans @waldekmastykarz
Fixes spinner when logging verbose messages. Closes #5378
ee94cb2
waldekmastykarz pushed a commit that referenced this issue Aug 26, 2023
@milanholemans @waldekmastykarz
Fixes spinner when logging verbose messages. Closes #5378
d58275c
waldekmastykarz pushed a commit that referenced this issue Aug 26, 2023
@milanholemans @waldekmastykarz
Fixes spinner when logging verbose messages. Closes #5378
7d5f98e
Jwaegebaert pushed a commit that referenced this issue Aug 26, 2023
@milanholemans @Jwaegebaert
Fixes spinner when logging verbose messages. Closes #5378
1f0f947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milanholemans milanholemans

Labels
bug work in progress
Projects
None yet
Milestone
v7
Development

Successfully merging a pull request may close this issue.

Fixes spinner when logging verbose messages milanholemans/cli-microsoft365
2 participants
@waldekmastykarz @milanholemans