Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement disambiguation prompt for 'teams app update' command #5490

Closed
martinlingstuyl opened this issue Sep 15, 2023 · 6 comments
Closed

Implement disambiguation prompt for 'teams app update' command #5490

martinlingstuyl opened this issue Sep 15, 2023 · 6 comments
Assignees
@Adam-it
Labels
enhancement
Milestone
v7.2

Comments

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Sep 15, 2023 •
edited

We forgot one command when adding disambiguation prompts in #5053 @Adam-it...

teams app update.

Also, lets fix the Cli.prompt in the following file:
src/m365/base/AppCommand.ts
@martinlingstuyl martinlingstuyl added this to the v7 milestone Sep 15, 2023
@Adam-it
Copy link
Contributor

Adam-it commented Sep 15, 2023

Why is this a breaking change 🤔?

@Adam-it
Copy link
Contributor

Adam-it commented Sep 15, 2023

I'll take it 👍

@Adam-it Adam-it self-assigned this Sep 15, 2023
@martinlingstuyl
Copy link
Contributor Author

Why is this a breaking change 🤔?

Oh, wasn't it? In that case 😁

@martinlingstuyl
Copy link
Contributor Author

@Adam-it, could you also check src/m365/base/AppCommand.ts? There's a Cli.prompt in there doing the work of your handle function.

@Adam-it
Copy link
Contributor

Adam-it commented Sep 19, 2023

@Adam-it, could you also check src/m365/base/AppCommand.ts? There's a Cli.prompt in there doing the work of your handle function.

Sure. TBH I didn't expect this kind of logic in the abstract class 😉👍

@waldekmastykarz waldekmastykarz removed this from the v7 milestone Sep 21, 2023
Adam-it added a commit to Adam-it/cli-microsoft365 that referenced this issue Oct 15, 2023
@Adam-it
Implement disambiguation prompt in missing places. Closes pnp#5490
33c7677
@Adam-it Adam-it mentioned this issue Oct 15, 2023
Closed
@Adam-it
Copy link
Contributor

Adam-it commented Oct 15, 2023 •
edited

@martinlingstuyl sorry for the hold-up from my side 🙏
PR opened.

@martinlingstuyl martinlingstuyl added this to the v7.2 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
enhancement
Projects
None yet
Milestone
v7.2
Development

Successfully merging a pull request may close this issue.

Implement disambiguation prompt in missing places. Closes #5490 Adam-it/cli-microsoft365
3 participants
@martinlingstuyl @waldekmastykarz @Adam-it