Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: add a config key to set the default login authType #5585

Closed
martinlingstuyl opened this issue Oct 23, 2023 · 1 comment
Closed

Enhancement: add a config key to set the default login authType #5585

martinlingstuyl opened this issue Oct 23, 2023 · 1 comment
Assignees
@martinlingstuyl
Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress
Milestone
v7.2

Comments

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Oct 23, 2023 •
edited

By default, running m365 login will trigger the device-code flow. However, some users may want to set the browser flow as default. We could enhance this by adding a config key which determines the default login authType:

Setting name Definition Default value
authType Default login method to use when running m365 login without the --authType option. deviceCode
@martinlingstuyl martinlingstuyl added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Oct 23, 2023
@waldekmastykarz
Copy link
Member

Nice! Ship it

@waldekmastykarz waldekmastykarz added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Oct 24, 2023
martinlingstuyl added a commit to martinlingstuyl/cli-microsoft365 that referenced this issue Oct 24, 2023
@martinlingstuyl
Adds a config key to set the default login authType. Closes pnp#5585
3e5be0d
@martinlingstuyl martinlingstuyl self-assigned this Oct 24, 2023
@martinlingstuyl martinlingstuyl added work in progress hacktoberfest Issue perfect for hacktoberfest and removed help wanted labels Oct 24, 2023
@martinlingstuyl martinlingstuyl mentioned this issue Oct 24, 2023
Closed
martinlingstuyl added a commit to martinlingstuyl/cli-microsoft365 that referenced this issue Nov 19, 2023
@martinlingstuyl
Adds a config key to set the default login authType. Closes pnp#5585
d03852a
@Adam-it Adam-it added this to the v7.2 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlingstuyl martinlingstuyl

Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress
Projects
None yet
Milestone
v7.2
Development

Successfully merging a pull request may close this issue.

Adds a config key to set the default login authType. Closes #5585 martinlingstuyl/cli-microsoft365
3 participants
@martinlingstuyl @waldekmastykarz @Adam-it