Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Wrong option in information about commands for Outlook-Report #5681

Closed
gavdgavd opened this issue Nov 18, 2023 · 6 comments
Closed
Assignees
Milestone

Comments

@gavdgavd
Copy link
Contributor

Priority

(Low) Something is a little off

Description

All the commands in the description of the section Outlook-Report indicate that there is a parameter called "--outputFile [outputFile]". This parameter doesn't exist. To redirect the output of the command to a different output than the screen, you need to use the normal redirection command (">"), as the examples correctly mention.

Steps to reproduce

Try to use any of the commands mentioned in the section Outlook-Report using the parameter "--outputFile"

Expected results

The results of the command should be redirected to an output file

Actual results

An error "Error: Invalid option: 'outputFile'"

Diagnostics

Not necessary. It is just a correction in the text of the instructions for the commands

CLI for Microsoft 365 version

7.1.0.

nodejs version

18.15.0.

Operating system (environment)

Windows

Shell

PowerShell

cli doctor

No response

Additional Info

It is only a correction for the information shown on the site.

@gavdgavd gavdgavd added the bug label Nov 18, 2023
@martinlingstuyl
Copy link
Contributor

Hi @gavdgavd, can you point me to a location in the docs where this is so? All I can find are yammer commands with this option...

@milanholemans
Copy link
Contributor

Hi @martinlingstuyl, I think he means that in the docs we state that there is an option called outputFile while in fact, there is no option with this name (anymore).

Seems like this is indeed a 'bug' in our docs. Are you willing to fix this @gavdgavd or shall we open it up for the community?

@gavdgavd
Copy link
Contributor Author

Hi Martin and Milan. Yes, Milan is right, the "bug" (it is not a bug but an issue with the docs) refers only to the information in the docs. I see that the same problem is also in the "Microsoft 365 tenant - report - report activeusercounts" (https://pnp.github.io/cli-microsoft365/cmd/tenant/report/report-activeusercounts) and "Microsoft 365 tenant - report - report activeuserdetail" (https://pnp.github.io/cli-microsoft365/cmd/tenant/report/report-activeuserdetail).
If you consider it appropriate, I can fix it in the documentation. I assume I need some kind of rights to do it self, right?
Many thanks for your quick response.
Gustavo

@milanholemans
Copy link
Contributor

Hi @gavdgavd, in our docs you can find a section where you can learn how to contribute. There you lean how to setup aan fork and create a pull request where you can fix this.

If that's too much work for you, we can open the issue up for someone else if you want.

@gavdgavd
Copy link
Contributor Author

Hi Milan,
Give me a couple of days to build a development environment for the CLI, and I’ll fix it myself. You will see the PR with the changes then.
Thanks, Gustavo

@milanholemans
Copy link
Contributor

Hi, @gavdgavd you can leave the issue open, this way we don't lose track of it.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants