Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command m365 spo tenant site unarchive #6043

Closed

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #6019

Something that I noticed that it could take some time before the SP admin center updates the Archived list, but the site gets accessible immediately. Should we add an info regarding this?

@milanholemans
Copy link
Contributor

Thank you, we'll review it ASAP!

@milanholemans milanholemans self-assigned this May 12, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's change a few things before we ship it.

docs/docs/cmd/spo/site/site-unarchive.mdx Outdated Show resolved Hide resolved
src/m365/spo/commands.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-unarchive.spec.ts Outdated Show resolved Hide resolved
docs/docs/cmd/spo/site/site-unarchive.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft June 12, 2024 21:08
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review June 20, 2024 13:09
@MathijsVerbeeck MathijsVerbeeck changed the title Adds command m365 spo site unarchive Adds command m365 spo tenant site unarchive Jun 20, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very neat! Made a few tiny changes while merging.


## More information

Pricing model for Microsoft 365 Archive: [https://learn.microsoft.com/microsoft-365/archive/archive-pricing](https://learn.microsoft.com/microsoft-365/archive/archive-pricing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pricing model for Microsoft 365 Archive: [https://learn.microsoft.com/microsoft-365/archive/archive-pricing](https://learn.microsoft.com/microsoft-365/archive/archive-pricing)
- Pricing model for Microsoft 365 Archive: [https://learn.microsoft.com/microsoft-365/archive/archive-pricing](https://learn.microsoft.com/microsoft-365/archive/archive-pricing)

});

await command.action(logger, { options: { url: url, verbose: true } });
assert(postStub.calledOnce);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check for the request body instead.

@milanholemans
Copy link
Contributor

Merged manually, many thanks for this command!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: spo tenant site unarchive
2 participants