Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 spe container permission remove #6161

Open
Adam-it opened this issue Jul 19, 2024 · 5 comments
Open

New command: m365 spe container permission remove #6161

Adam-it opened this issue Jul 19, 2024 · 5 comments

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Jul 19, 2024

Usage

m365 spe container permission remove [options]

Description

Removes permissions from a SharePoint Embedded Container

Options

Option Description
-i, --id <id> ID of the permission to remove.
--containerId <containerId> ID of a SharePoint Embedded Container.
-f, --force [force] Don't prompt for confirmation.

Examples

Removes the specified permission from a container

m365 spe container permission remove --containerId "b!ISJs1WRro0y0EWgkUYcktDa0mE8zSlFEqFzqRn70Zwp1CEtDEBZgQICPkRbil_5Z"  --Id "cmVhZGVyX2k6MCMuZnxtZW1iZXJzaGlwfHJvcnlicjExMUBvdXRsb29rLmNvbQ"

Removes the specified permission from a container and doesn't prompt for confirmation

m365 spe container permission remove --containerId "b!ISJs1WRro0y0EWgkUYcktDa0mE8zSlFEqFzqRn70Zwp1CEtDEBZgQICPkRbil_5Z"  --Id "cmVhZGVyX2k6MCMuZnxtZW1iZXJzaGlwfHJvcnlicjExMUBvdXRsb29rLmNvbQ" --force

Default properties

No response

Additional Info

We may use the following API:
https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-delete-permissions?view=graph-rest-1.0&tabs=http

@Adam-it Adam-it added new feature needs peer review Needs second pair of eyes to review the spec or PR labels Jul 19, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 23, 2024

@milanholemans, @Jwaegebaert I applied similar changes from the comments I got from you in other spe commands.
Do you see anything else? or should we open it up?

@milanholemans
Copy link
Contributor

I made a few tiny changes, but LGTM 👍

@milanholemans milanholemans added help wanted needs peer review Needs second pair of eyes to review the spec or PR and removed needs peer review Needs second pair of eyes to review the spec or PR help wanted labels Jul 23, 2024
@milanholemans
Copy link
Contributor

Shouldn't it be named id instead of permissionId?

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 23, 2024

Shouldn't it be named id instead of permissionId?

aaa right. since permission is the object we are working on.. makes sense. I will update the spec

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 23, 2024

@milanholemans how about now?

@milanholemans milanholemans added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants