Escaped pipe and replaced comma solving #1420 #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you! 👏 |
|
Replaced the escaped pipe pattern with an html encoded representation of the pipe char, as suggested by @garrytrinder |
VelinGeorgiev
approved these changes
Apr 11, 2020
There was a problem hiding this comment.
Thank you very much Joakim @jhagstrom ! 🚀 🚀 🚀 You've done a great job! I scanned through the changed files and it all looks great. I did few minor changes and you can see them in the comments below.
Your PR will be merged from this branch: https://github.com/VelinGeorgiev/office365-cli/tree/fix-pipes-in-doc-1420
| @@ -42,7 +42,7 @@ assignees: '' | |||
| | Option | Description | | |||
| | ----------------------- | ----------------------------------------- | | |||
| | `-o, --option <option>` | option | | |||
| | `-o, --output [output]` | Output type. `json\|text`. Default `text` | | |||
| | `-o, --output [output]` | Output type. `json`|`text`. Default `text` | | |||
There was a problem hiding this comment.
I replaced json|text with json,text
| `--allowEveryoneViewItems [allowEveryoneViewItems]`|Boolean value specifying whether everyone can view documents in the documentlibrary or attachments to items in the list. Valid values are `true,false` | ||
| `--allowMultiResponses [allowMultiResponses]`|Boolean value specifying whether users are allowed to give multiple responses to the survey. Valid values are `true,false` | ||
| `--contentTypesEnabled [contentTypesEnabled]`|Boolean value specifying whether content types are enabled for the list. Valid values are `true,false` | ||
| `--crawlNonDefaultViews [crawlNonDefaultViews]`|Boolean value specifying whether to crawl non default views. Valid values are `true,false` | ||
| `--defaultContentApprovalWorkflowId [defaultContentApprovalWorkflowId]`|Value that specifies the default workflow identifier for content approval on the list (GUID) | ||
| `--defaultDisplayFormUrl [defaultDisplayFormUrl]`|Value that specifies the location of the default display form for the list | ||
| `--defaultEditFormUrl [defaultEditFormUrl]`|Value that specifies the URL of the edit form to use for list items in the list | ||
| `--description [description]`|The description for the list | ||
| `--direction [direction]`|Value that specifies the reading order of the list. Valid values are NONE|LTR|RTL |
There was a problem hiding this comment.
NONE|LTR|RTL replaced with NONE,LTR,RTL
| `--defaultContentApprovalWorkflowId [defaultContentApprovalWorkflowId]`|Value that specifies the default workflow identifier for content approval on the list (GUID) | ||
| `--defaultDisplayFormUrl [defaultDisplayFormUrl]`|Value that specifies the location of the default display form for the list | ||
| `--defaultEditFormUrl [defaultEditFormUrl]`|Value that specifies the URL of the edit form to use for list items in the list | ||
| `--description [description]`|The description for the list | ||
| `--direction [direction]`|Value that specifies the reading order of the list. Valid values are NONE|LTR|RTL | ||
| `--disableGridEditing [disableGridEditing]`|Property for assigning or retrieving grid editing on the list. Valid values are true|false | ||
| `--disableGridEditing [disableGridEditing]`|Property for assigning or retrieving grid editing on the list. Valid values are `true,false` | ||
| `--draftVersionVisibility [draftVersionVisibility]`|Value that specifies the minimum permission required to view minor versions and drafts within the list. Allowed values Reader|Author|Approver. Default Reader |
There was a problem hiding this comment.
Reader|Author|Approver replaced with Reader,Author,Approver
|
Merged manually. Thank you! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went through .md files and replaced unescaped pipe with escaped pipe where I found it. Also replaced a few occasions of commas between command options with pipe and added back-tics where missing.