New Command - spo roledefinition list #3269
Conversation
|
Awesome! We'll review it shortly |
| ## Options | ||
|
|
||
| `-u, --webUrl <webUrl>` | ||
| : URL of the site where the role definitions to retrieve are located |
There was a problem hiding this comment.
We can simplify this to URL of the site for which to retrieve role definition
| }; | ||
|
|
||
| request | ||
| .get<any>(requestOptions) |
There was a problem hiding this comment.
The return type for the request shouldn't be any but rather value: any[] so that in the res property we get the known value array.
| request | ||
| .get<any>(requestOptions) | ||
| .then((response: { value: any[] }): void => { | ||
| logger.log(response); |
There was a problem hiding this comment.
We should remove the value array from the response and instead pass the array items directly to the output. This is consistent with other commands
| const command: Command = require('./roledefinition-list'); | ||
|
|
||
| describe(commands.ROLEDEFINITION_LIST, () => { | ||
|
|
There was a problem hiding this comment.
Let's remove this empty line
|
|
||
| it('passes validation if the webUrl option is a valid SharePoint site URL', () => { | ||
| const actual = command.validate({ options: { webUrl: 'https://contoso.sharepoint.com' } }); | ||
| assert(actual); |
There was a problem hiding this comment.
This should be assert.strictEqual. With just an assert the test will pass even if validation failed.
| sinon.stub(request, 'get').callsFake((opts) => { | ||
| if ((opts.url as string).indexOf('/_api/web/roledefinitions') > -1) { | ||
| return Promise.resolve( | ||
| [ |
There was a problem hiding this comment.
This mock response is incorrect. The array of role definitions should be wrapped in a value object
|
Merged manually. Thank you! 馃憦 |
|
thanks @waldekmastykarz for the fixes 馃ぉ |
New Command - spo roledefinition list
The aim of this PR is to add a new command which will allow to list role definitions from web
Linked Issue
Closes #3237
馃摳 Result
json output
text output