Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend spo listitem with listUrl (part 1) #3889

Closed
wants to merge 3 commits into from
Closed

Extend spo listitem with listUrl (part 1) #3889

wants to merge 3 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #3813

@milanholemans
Copy link
Contributor

Splendid @MathijsVerbeeck
We'll review it ASAP!

@Adam-it Adam-it self-assigned this Oct 25, 2022
Adam-it
Adam-it requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just one small detail we may improve along the way and I think we are good to go

src/m365/spo/commands/listitem/listitem-list.ts Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft October 25, 2022 22:51
@Adam-it Adam-it added needs peer review Needs second pair of eyes to review the spec or PR hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 25, 2022
@Adam-it
Copy link
Contributor

Adam-it commented Oct 25, 2022

@pnp/cli-for-microsoft-365-maintainers anyone up for a second opinion?

@MathijsVerbeeck
Copy link
Contributor Author

Hi @Adam-it
Thanks for the feedback. I agree that it could be programmed better, however these options are deprecated and already removed from the v6 branch, so I didn't write it like that as I thought that it would be harder to change it when moving this to the v6 branch.

I will resolve the remark tomorrow 😄

@Adam-it
Copy link
Contributor

Adam-it commented Oct 26, 2022

Hi @Adam-it Thanks for the feedback. I agree that it could be programmed better, however these options are deprecated and already removed from the v6 branch, so I didn't write it like that as I thought that it would be harder to change it when moving this to the v6 branch.

I will resolve the remark tomorrow 😄

TBH I noticed those were deprecated but I just couldn't stop myself from refactoring it 😅.
Ok what you wrote is also valid so let's leave it how it is now and wait for second review before I push this one👍

@Adam-it Adam-it marked this pull request as ready for review October 26, 2022 06:48
@Adam-it Adam-it removed the needs peer review Needs second pair of eyes to review the spec or PR label Oct 28, 2022
Adam-it
Adam-it approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled and tested locally, looks good ✔
awesome work @MathijsVerbeeck 👍
you rock 🤩

@Adam-it
Copy link
Contributor

Adam-it commented Oct 28, 2022

ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented Oct 28, 2022

merged manually.
thank you for your awesome work 🤩

@Adam-it Adam-it closed this Oct 28, 2022
@MathijsVerbeeck MathijsVerbeeck deleted the extend-spo-listitem-v1 branch May 25, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure all spo listitem commands have all available list options
3 participants
@MathijsVerbeeck @milanholemans @Adam-it