Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docs output: teams app until teams membersettings commands. Closes #3935 #4008

Closed
wants to merge 6 commits into from

Conversation

nicodecleyre
Copy link
Contributor

This pr updates the docs output: from teams app until teams membersettings commands.

Closes #3935

@nicodecleyre nicodecleyre changed the title Updates docs output: teams app until teams membersettings commands Updates docs output: teams app until teams membersettings commands. Closes #3935 Nov 6, 2022
@Jwaegebaert
Copy link
Contributor

Awesome job @nicodecleyre
We'll review it ASAP!

@milanholemans milanholemans self-assigned this Nov 6, 2022
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicodecleyre thank you for great work! We're almost there.
I've created few remarks, could you have a look at them please?

docs/docs/cmd/teams/app/app-publish.md Outdated Show resolved Hide resolved
docs/docs/cmd/teams/channel/channel-add.md Show resolved Hide resolved
docs/docs/cmd/teams/channel/channel-member-add.md Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft November 6, 2022 16:17
@nicodecleyre nicodecleyre marked this pull request as ready for review November 6, 2022 20:19
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Nothing to add!

@milanholemans
Copy link
Contributor

Merged manually, thank you! 👏

@nicodecleyre nicodecleyre deleted the teams-docs-part-2 branch November 7, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include response output: teams app until teams membersettings commands
3 participants