Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 entra user groupmembership list. Closes #5904 #5924

Conversation

MartinM85
Copy link
Contributor

Closes #5904

@Jwaegebaert
Copy link
Contributor

Thank you @MartinM85, we'll try to review it ASAP!

@Adam-it Adam-it self-assigned this May 16, 2024
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinM85 awesome work 👏. You Rock 🤩
my biggest concern is regarding the trimmed output. Especially for csv and md it is not correct. Please double check my comments and let's see how we may correct it

docs/docs/cmd/entra/user/user-groupmembership-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/user/user-groupmembership-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/user/user-groupmembership-list.mdx Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-groupmembership-list.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft May 16, 2024 23:11
@MartinM85 MartinM85 force-pushed the feature/5904-entra-user-groupmembership-list branch from 09f6af5 to 3ba71d8 Compare May 17, 2024 05:48
@MartinM85 MartinM85 marked this pull request as ready for review May 17, 2024 06:02
@MartinM85 MartinM85 requested a review from Adam-it May 17, 2024 06:02
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
@MartinM85 You Rock 🤩

@Adam-it
Copy link
Contributor

Adam-it commented May 19, 2024

Ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented May 20, 2024

Merged manually. You Rock 🤩👏

@Adam-it Adam-it closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 entra user groupmembership list
3 participants