-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: Create PowerApps component framework project structure #952
Comments
Nice! I've updated the description a little, but other than that, ready to go! 💪 |
Have you left feedback on the PowerApps forum for PCF for this issue (https://aka.ms/PCFForum) before shoehorning it into an office tool? |
Thanks for the pointer @ghurlman. |
@waldekmastykarz, saw your post, thanks! I’ll make sure the PCF CLI team sees it if you don’t get a timely response. |
Thank you! Appreciate your help! 👏 |
@waldekmastykarz I finally gave this a shot, while familiarizing myself with the code structure. Current implementation can be found at https://github.com/YannickRe/office365-cli/tree/pa-pcf-init Before I go any further with this, do you mind checking this and give pointers?
Would you rather I submit this as a work in progress PR? |
I'll have a look at it asap. Thanks! It will be a good first step to be able to create a project using the same templates as the original PCF tooling. In the end we should strive to create projects that can also be built on any platform, which will require reverse-engineering the build process and adjusting the templates. |
Thank you! I’m aiming to make the tooling and all the commands work cross platform, and I hope I can convince some MS people to make minor changes in their NPM packages so they work cross platform 😉 |
@waldekmastykarz Sorry to push, but did you have a chance to look into this? I'd like your input before trying to get code coverage/starting other commands. |
Sorry, I was away and didn't have time to look into it. Thanks for the reminder though. I'll have a look at it shortly. |
The current setup looks solid. Nicely done 👍 |
Thank you! I made some changes according to your comments, but I squashed my commits, unintentionally removing them :(
I'll get there, time to figure out how to reach the necessary test coverage :) |
Suppressing auth for all |
I moved away from For testing the filesystem, can I use |
We have some mocking for the file system in the SPFx command, you can have a look at that. With regards to testing, it should be enough for us to test that the Node.js copy method is called with the right arguments. We should be able to assume that it works correctly so we don't need to test if the file is actually copied, that's Node's responsibility. |
Creates new PowerApps component framework project
pa pcf init --namespace <namespace> --name <name> --template <template>
Equivalent to the PowerApps CLI command.
The text was updated successfully, but these errors were encountered: