Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing Missing from NuGet #943

Closed
1 task done
clurdish opened this issue Aug 18, 2022 · 2 comments · Fixed by #945
Closed
1 task done

Licensing Missing from NuGet #943

clurdish opened this issue Aug 18, 2022 · 2 comments · Fixed by #945
Assignees

Comments

@clurdish
Copy link

clurdish commented Aug 18, 2022

Category

  • Bug

Describe the bug

Packages published to NuGet are missing the licensing property, which should be MIT according to this repository.

My understanding is that the .csproj files are missing a licensing definition as defined in NuGet documentation (here and here). Example below.

<Project Sdk="Microsoft.NET.Sdk">
    ....
    <PropertyGroup>
        <PackageLicenseExpression>MIT</PackageLicenseExpression>
    </PropertyGroup>
</Project>

Steps to reproduce

  1. Navigate to NuGet (any version of any of the packages published by this repository).
    a. Example: https://www.nuget.org/packages/PnP.Core.Auth
  2. No license is listed for the package

Expected behavior

I expect the MIT license to be listed on each package listed on NuGet.

Environment details (development & target environment)

  • SDK version: 1.7.0
  • OS: WIndows 10
  • SDK used in: Azure Function v4
  • Framework: .NET 6
  • Browser(s): Chrome v104
  • Tooling: Visual Studio 2022
  • Additional details: This is reproducible from any platform/tooling from what I can tell

Additional context

I'm working in a space where all third-party dependencies are scanned by a tool called Sonatype Nexus Lifecycle OSS. Any packages that are missing licensing are rejected with a critical legal warning. PnP.Core was flagged by this system.

Thanks for your contribution! Sharing is caring.

@0-0-1-0-1-0-1-0
Copy link

This is also true for all the PnP.Core.X packages as well (Auth, Admin, Transformation, Transformation.Sharepoint).

@jansenbe
Copy link
Contributor

Good point @clurdish , I'll merge your PR as we indeed should specify license information in our nuget packages

@jansenbe jansenbe self-assigned this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants