Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adalfetchclient: Type definition is not found #45

Closed
1 of 4 tasks
estruyf opened this issue Mar 12, 2018 · 5 comments · Fixed by #50
Closed
1 of 4 tasks

adalfetchclient: Type definition is not found #45

estruyf opened this issue Mar 12, 2018 · 5 comments · Fixed by #50

Comments

@estruyf
Copy link
Member

estruyf commented Mar 12, 2018

Category

  • Enhancement
  • Bug
  • Question
  • Documentation gap/issue

Version

Please specify what version of the library you are using: [1.0.3]

Expected / Desired Behavior / Question

Typings reference for types.d.ts is not found. When transpiling TS to JS I get the following error:

node_modules/@pnp/nodejs/src/net/adalfetchclient.d.ts(1,22): error TS6053: File '/Users/user/project/packages/nodejs/src/net/types.d.ts' not found.

screenshot 2018-03-12 19 38 10

@patrick-rodgers
Copy link
Member

That is the node client - do you mean to be running in node or browser?

@estruyf
Copy link
Member Author

estruyf commented Mar 13, 2018

Running it on node

@patrick-rodgers
Copy link
Member

Hmmm...in the file that reference is /// <reference path="types.d.ts" /> to a local file - unsure what it is being rewritten and I am not able to duplicate currently.

@patrick-rodgers
Copy link
Member

Confirmed that the types.d.ts isn't copied into the final package. Figuring out how best to address.

@github-actions
Copy link

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants