Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Leave Request Template #90

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

aprildunnam
Copy link
Contributor

New leave request Power App Template

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

(DELETE THIS PARAGRAPH AFTER READING)

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

New leave request Power App Template
Copy link

Validation failed!

File: samples/leave-request/assets/sample.json

Copy link
Contributor

@Katerina-Chernevskaya Katerina-Chernevskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aprildunnam ,

Thank you! Awesome!
I slightly adjusted the readme file (point to the generated solution and replace with your name and solution title links in the Help section), and aligned the sample.json file with the template.
I'm going to merge the PR.

Kate

@Katerina-Chernevskaya Katerina-Chernevskaya merged commit 1b0dc16 into pnp:main Apr 23, 2024
1 check failed
@aprildunnam
Copy link
Contributor Author

Thank you for catching my errors in the readme and fixing and thanks for processing so quickly @Katerina-Chernevskaya !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants