Fix case sensitivity issue in Get-PnPGroup for consisitency and add c…

…onsistent null checks with exceptions.
pnp · Apr 28, 2022 · 1527d49 · 1527d49
1 parent 0a9d980
commit 1527d49
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 8 deletions.
diff --git a/documentation/Get-PnPGroup.md b/documentation/Get-PnPGroup.md
@@ -59,7 +59,7 @@ Returns all SharePoint groups in the current site
 Get-PnPGroup -Identity 'My Site Users'
 ```
 
-This will return the group called 'My Site Users' if available in the current site
+This will return the group called 'My Site Users' if available in the current site. The name is case sensitive, so a group called 'My site users' would not be found.
 
 ### EXAMPLE 3
 ```powershell
@@ -127,7 +127,7 @@ Accept wildcard characters: False
 ```
 
 ### -Identity
-Get a specific group by its name or id
+Get a specific group by its name or id. The name case sensitive.
 
 ```yaml
 Type: GroupPipeBind

diff --git a/src/Commands/Principals/GetGroup.cs b/src/Commands/Principals/GetGroup.cs
@@ -26,8 +26,25 @@ protected override void ExecuteCmdlet()
         {
             if (ParameterSetName == "ByName")
             {
-                Group group = Identity.GetGroup(CurrentWeb);
-                WriteObject(group);
+                // Get group by name using Core SDK because of
+                // case sensitivity difference between Core SDK and CSOM
+                // Loads group using CSOM to bypass a breaking change
+                var pnpGroup = Identity.GetGroup(PnPContext);
+
+                if (pnpGroup != null)
+                {
+                    var csomGroup = CurrentWeb.SiteGroups.GetById(pnpGroup.Id);
+                    ClientContext.Load(csomGroup);
+                    ClientContext.Load(csomGroup.Users);
+                    ClientContext.ExecuteQueryRetry();
+
+                    WriteObject(csomGroup);
+                }
+                else
+                {
+                    throw new PSArgumentException("Site group not found", nameof(Identity));
+                }
+
             }
             else if (ParameterSetName == "Members")
             {

diff --git a/src/Commands/Principals/GetGroupPermissions.cs b/src/Commands/Principals/GetGroupPermissions.cs
@@ -15,11 +15,15 @@ public class GetGroupPermissions : PnPWebCmdlet
 
         protected override void ExecuteCmdlet()
         {
-            var g = Identity.GetGroup(PnPContext);
-            var r = g.GetRoleDefinitions();
-            if (r != null)
+            var group = Identity.GetGroup(PnPContext);
+
+            if (group == null)
+                throw new PSArgumentException("Site group not found", nameof(Identity));
+
+            var roleDefinitions = group.GetRoleDefinitions();
+            if (roleDefinitions != null)
             {
-                WriteObject(r.RequestedItems, true);
+                WriteObject(roleDefinitions.RequestedItems, true);
             }
         }
     }

diff --git a/src/Commands/Principals/SetGroupPermissions.cs b/src/Commands/Principals/SetGroupPermissions.cs
@@ -24,6 +24,10 @@ public class SetGroupPermissions : PnPWebCmdlet
         protected override void ExecuteCmdlet()
         {
             var group = Identity.GetGroup(PnPContext);
+
+            if (group == null)
+                throw new PSArgumentException("Site group not found", nameof(Identity));
+
             PnP.Core.Model.SharePoint.IList list = null;
             if (ParameterSpecified(nameof(List)))
             {