Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Param positions removed #1384

Merged
merged 3 commits into from
Nov 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed `Add/Set-PnPListItem` issue with managed metadata / taxonomy field value failing in a batched request.
- Fixed `Set-PnPListItem` issue with setting `Modified` date value properly when using `-Batch` parameter.
- Fixed `Get-PnPTeamsTeam -Identity` throwing an exception if the name of the team would contain special characters
- Fixed `Get-PnPTerm` throwing an exception when used in combination with `-Includes` [#1384](https://github.com/pnp/powershell/pull/1384)
- Fixed `Get-PnPDiagnostics` throwing an unable to cast exception under some circumstances [#1380](https://github.com/pnp/powershell/pull/1380)

### Removed
Expand All @@ -83,6 +84,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [Andy-Dawson]
- David Aeschlimann [TashunkoWitko]
- [outorted]
- [dkardokas]
- Asad Refai [asadrefai]
- Giacomo Pozzoni [jackpoz]

Expand Down
4 changes: 2 additions & 2 deletions src/Commands/Taxonomy/GetTerm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ public class GetTerm : PnPRetrievalsCmdlet<Term>
[Parameter(Mandatory = false, ParameterSetName = ParameterSet_TERMNAME)]
public TaxonomyTermPipeBind Identity;

[Parameter(Mandatory = true, ValueFromPipeline = true, Position = 0, ParameterSetName = ParameterSet_TERMNAME)]
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet_TERMNAME)]
public TaxonomyTermSetPipeBind TermSet;

[Parameter(Mandatory = true, ValueFromPipeline = true, Position = 0, ParameterSetName = ParameterSet_TERMNAME)]
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet_TERMNAME)]
public TaxonomyTermGroupPipeBind TermGroup;

[Parameter(Mandatory = false, ParameterSetName = ParameterSet_TERMID)]
Expand Down