Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Microsoft 365 Group Endpoint cmdlets #2038

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

KoenZomers
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

N/A

What is in this Pull Request ?

  • Added Get-Microsoft365GroupYammerCommunity cmdlet to retrieve details on the Yammer Community connected to a Microsoft 365 Group
  • Added Get-Microsoft365GroupTeam cmdlet to retrieve details on the Microsoft Teams team connected to a Microsoft 365 Group
  • Added Get-Microsoft365GroupEndpoints cmdlet to retrieve details on all endpoints connected to a Microsoft 365 Group

@gautamdsheth
Copy link
Collaborator

gautamdsheth commented Jun 27, 2022

@KoenZomers - can we please use Microsoft365GroupPipeBind here instead of GUID ? Would make it much easier to validate and make it consistent with other M365 Group related cmdlets.
Also, we can then just throw the error if the Group is not found like this, instead of warning:

throw new PSInvalidOperationException("Group not found");

Am talking about the PnPMicrosoft365GroupYammerCommunity cmdlet

@KoenZomers
Copy link
Collaborator Author

@gautamdsheth Its already using the pipebind?

@gautamdsheth
Copy link
Collaborator

Sorry, my bad.

About this condition:

if(groupId == Guid.Empty)
                {
                    WriteWarning("Current site is not backed by a Microsoft 365 Group");
                }

Can we just throw the error for this ? Because, I am guessing the Graph call will also fail for this

@KoenZomers
Copy link
Collaborator Author

Good point, well spotted, I'll update it!

@KoenZomers
Copy link
Collaborator Author

@gautamdsheth Ready for final review.

@gautamdsheth gautamdsheth merged commit 05d0133 into pnp:dev Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants