fix of #895

pnp · May 15, 2021 · 394de18 · 394de18
1 parent caf2d16
commit 394de18
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.JSON b/CHANGELOG.JSON
@@ -6,7 +6,7 @@
         "new": [],
         "enhancements": [],
         "fixes": [
-          "Documentation for `RichText`: correct event handler name [#898](https://github.com/pnp/sp-dev-fx-controls-react/pull/898)",
+          "Documentation for `RichText`: correct event handler name [#898](https://github.com/pnp/sp-dev-fx-controls-react/pull/898)"
         ]
       },
       "contributions": [

diff --git a/src/controls/sitePicker/SitePicker.tsx b/src/controls/sitePicker/SitePicker.tsx
@@ -148,7 +148,7 @@ export const SitePicker: React.FunctionComponent<ISitePickerProps> = (props: Rea
           key: s.url,
           text: s.title,
           data: s,
-          selected: selectedSitesIds.indexOf(s.url) !== -1
+          //selected: selectedSitesIds.indexOf(s.url) !== -1
         });
       });
     }
@@ -207,7 +207,11 @@ export const SitePicker: React.FunctionComponent<ISitePickerProps> = (props: Rea
 
       return sites;
     });
-  }, [initialSites]);
+
+    if (!allSites) {
+      setIsLoading(true);
+    }
+  }, [initialSites, allSites]);
 
   React.useEffect(() => {
     if (!context || !isLoading) {