Merge pull request #994 from gautamdsheth/bugfix/translation-again

Fix - missing translation keys
pnp · Sep 2, 2021 · 3e795c0 · 3e795c0
2 parents 43a9662 + b77779b
commit 3e795c0
Show file tree

Hide file tree

Showing 28 changed files with 9,731 additions and 8,783 deletions.
diff --git a/scripts/execute-translation.js b/scripts/execute-translation.js
@@ -35,7 +35,7 @@ async function getAuthToken() {
 
     const options = {
       method: 'POST',
-      url: 'https://westeurope.api.cognitive.microsoft.com/sts/v1.0/issueToken',
+      url: 'https://api.cognitive.microsoft.com/sts/v1.0/issueToken',
       headers: {
         'Ocp-Apim-Subscription-Key': subscriptionKey,
         'Content-type': 'application/x-www-form-urlencoded',
@@ -103,17 +103,22 @@ function compareTranslationKeys(srcObj, dstObj) {
   // Extract all the keys and set them in alpabetyical order
   let dstKeys = Object.keys(dstObj);
 
-  // Array<string>
   let toTranslate = [];
-  dstKeys.forEach((locKey) => {
-    if (typeof srcObj[locKey] !== "string") {
-      // In case we have nested translation objects
-      toTranslate = toTranslate.concat(compareTranslationKeys(srcObj[locKey], dstObj[locKey]));
-    } else if (srcObj[locKey] === dstObj[locKey]) {
-      // In case the english value is the same as localized one, add it to translate
-      toTranslate.push(srcObj[locKey]);
-    }
-  });
+  // Array<string>
+  try {    
+    dstKeys.forEach((locKey) => {
+      if (typeof srcObj[locKey] !== "string") {
+        // In case we have nested translation objects
+        toTranslate = toTranslate.concat(compareTranslationKeys(srcObj[locKey], dstObj[locKey]));
+      } else if (srcObj[locKey] === dstObj[locKey]) {
+        // In case the english value is the same as localized one, add it to translate
+        toTranslate.push(srcObj[locKey]);
+      }
+    });
+  } catch (error) {
+    console.log(error.message);
+  }
+
 
   return toTranslate;
 }

diff --git a/src/loc/bg-bg.ts b/src/loc/bg-bg.ts
diff --git a/src/loc/ca-es.ts b/src/loc/ca-es.ts
diff --git a/src/loc/da-dk.ts b/src/loc/da-dk.ts
diff --git a/src/loc/de-de.ts b/src/loc/de-de.ts
diff --git a/src/loc/el-gr.ts b/src/loc/el-gr.ts
diff --git a/src/loc/es-es.ts b/src/loc/es-es.ts
diff --git a/src/loc/et-ee.ts b/src/loc/et-ee.ts
diff --git a/src/loc/fi-fi.ts b/src/loc/fi-fi.ts
diff --git a/src/loc/fr-ca.ts b/src/loc/fr-ca.ts
diff --git a/src/loc/fr-fr.ts b/src/loc/fr-fr.ts
diff --git a/src/loc/it-it.ts b/src/loc/it-it.ts
diff --git a/src/loc/ja-jp.ts b/src/loc/ja-jp.ts
diff --git a/src/loc/lt-lt.ts b/src/loc/lt-lt.ts
diff --git a/src/loc/lv-lv.ts b/src/loc/lv-lv.ts
diff --git a/src/loc/nb-no.ts b/src/loc/nb-no.ts
diff --git a/src/loc/nl-nl.ts b/src/loc/nl-nl.ts
diff --git a/src/loc/pl-pl.ts b/src/loc/pl-pl.ts
diff --git a/src/loc/pt-pt.ts b/src/loc/pt-pt.ts
diff --git a/src/loc/ro-ro.ts b/src/loc/ro-ro.ts
diff --git a/src/loc/ru-ru.ts b/src/loc/ru-ru.ts
diff --git a/src/loc/sk-sk.ts b/src/loc/sk-sk.ts
diff --git a/src/loc/sr-latn-rs.ts b/src/loc/sr-latn-rs.ts
diff --git a/src/loc/sv-se.ts b/src/loc/sv-se.ts
diff --git a/src/loc/tr-tr.ts b/src/loc/tr-tr.ts
diff --git a/src/loc/vi-vn.ts b/src/loc/vi-vn.ts
diff --git a/src/loc/zh-cn.ts b/src/loc/zh-cn.ts
diff --git a/src/loc/zh-tw.ts b/src/loc/zh-tw.ts