Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView styles #1007

Closed
mkoutroupis opened this issue Sep 5, 2021 · 5 comments
Closed

ListView styles #1007

mkoutroupis opened this issue Sep 5, 2021 · 5 comments
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@mkoutroupis
Copy link

Category

[ ] Enhancement

[ ] Bug

[X] Question

Version

Please specify what version of the library you are using: [ 3.0.0 ]

Expected / Desired Behavior / Question

I would like to control the height of the ListView control by passing a className or styles object.
In the code, the wrapper has a set height of 50vh. While this is great in some occasions, when using a collapsible section or adding more controls under it, it appears weird. Is there a way to set the height of the wrapper?

Observed Behavior

Because of wrapper has a default height of 50vh, when trying to limit the size of the ListView, the results are appearing under the next control.

image

Steps to Reproduce

Create a SPFX webpart and wrap the ListView control with a div and set the height of the div to 300 px. Build it and serve it.
In the workbench, create 2 sections, add the webpart to both sections and populate them with as many items so that the scrollable pane appears.

Thanks!

@joelfmrodrigues joelfmrodrigues added type:enhancement New feature or enhancement of existing capability help wanted labels Sep 9, 2021
@joelfmrodrigues
Copy link
Collaborator

Hi @mkoutroupis thanks for the information provided, will definitely be a good improvement.
Would you be willing to work on it and submit a PR?

@MonalisaBaltatescu
Copy link

Hi, I want to contribute to this issue. Could you please assign me so I can start working on it?

@joelfmrodrigues
Copy link
Collaborator

@MonalisaBaltatescu assigned, thank you

@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Oct 23, 2021
@AJIXuMuK AJIXuMuK added this to the 3.5.0 milestone Oct 23, 2021
@MonalisaBaltatescu
Copy link

#1042

The above-linked PR fixes the issue, tt has been merged to dev

@joelfmrodrigues
Copy link
Collaborator

@MonalisaBaltatescu thanks for your contribution. Just a little note in case you are not aware: if you tag this issue on the PR, it will be automatically referenced.
The table below is a good example where this can be done:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

4 participants