Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxonomyPicker control allows select deprecated/untaggable terms when typing #1093

Closed
kallejar opened this issue Jan 14, 2022 · 5 comments
Closed
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@kallejar
Copy link

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[ x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.5.0 ]

Expected / Desired Behavior / Question

We have in our term set deprecated and untaggable terms set. On the control I have both these options true.
hideTagsNotAvailableForTagging={true} hideDeprecatedTags={true}

The true value works when you pick the terms via the tag-icon
image

But if you type directly to the control field you are able to find and pick the term
image
image
Console.log
image

I would expect both typing and selecting term via picker would work the same when using those control propeties

Observed Behavior

If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a
suggestion or asking a question delete this section.

Steps to Reproduce

I have following configuration for the control:
<TaxonomyPicker allowMultipleSelections={false} termsetNameOrID={this.props.webPartProperties.termSets.reportType.guid} panelTitle={strings.newReportTypeLabel} placeholder={strings.newReportTypeDescription} label={strings.newReportTypeLabel} context={this.props.context} onChange={this._onTaxPickerChangeReportTypeProxy} isTermSetSelectable={false} required={true} hideDeprecatedTags={true} hideTagsNotAvailableForTagging={true} />

There seems to have been similar issues in past
#506
#109

@ghost
Copy link

ghost commented Jan 14, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 14, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@manipk
Copy link

manipk commented Sep 1, 2022

Also request this issue to be resolved. Can we know the status on this bug

@ekapic
Copy link

ekapic commented Nov 9, 2022

Hi there!
I've fixed this issue in PR #1354

joelfmrodrigues added a commit that referenced this issue Nov 13, 2022
Suggested term filtering condition fixed (issue #1093)
@joelfmrodrigues
Copy link
Collaborator

@kallejar many thanks for reporting the issue.
The PR from @ekapic has now been merged and the fix will be in the beta release shortly. Will also be included in the next main release.

@joelfmrodrigues joelfmrodrigues added this to the 3.12.0 milestone Nov 13, 2022
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Nov 13, 2022
@AJIXuMuK AJIXuMuK mentioned this issue Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

5 participants