Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW CONTROL - Adaptive Card Host #1096

Closed
fabiofranzini opened this issue Jan 17, 2022 · 8 comments · Fixed by #1126
Closed

NEW CONTROL - Adaptive Card Host #1096

fabiofranzini opened this issue Jan 17, 2022 · 8 comments · Fixed by #1126

Comments

@fabiofranzini
Copy link
Collaborator

Hello,
I've been working with Adaptive Cards, I really like the new ACE model and in general I like the fact that I can describe the UI of a Web Part in a declarative way and be able to change it at runtime, like a configuration.

After some tests on this, I created a React control that allows you to render an Adaptive Card as a component, also using the templating part and the ability to invoke commands defined using the "Action.Execute" model.

I would like to make it a control of this library, what do you think?

@ghost
Copy link

ghost commented Jan 17, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 17, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@joelfmrodrigues
Copy link
Collaborator

Hi @fabiofranzini , that would be a great addition in my opinion. I was actually discussing this with @joaojmendes a few days ago as he was considering a similar control. Perhaps we could use this thread as a starting point to avoid duplication of effort and duplicated PRs?

Are you both able to describe your approach so we could all brainstorm the best way to move this forward and hopefully benefit from both solutions?

@fabiofranzini
Copy link
Collaborator Author

fabiofranzini commented Jan 18, 2022

Hi @joelfmrodrigues,
in recent days I chatted with @joaojmendes about this thing, we can join forces and bring the best of our solutions.

The idea is to have a control that can host Adaptive Cards in both Web Parts and Application Customizer, so that they can be used as a UI.

Also, as I have already implemented in some examples, we could extend the Adaptive Cards 'standard' set of controls with Fluent UI controls or as suggested by @joaojmendes with Microsoft Graph Toolkit controls.

@joaojmendes, we need to set up a call to discuss this :)

@AJIXuMuK
Copy link
Collaborator

@fabiofranzini @joaojmendes - also keep in mind there is a web part sample with AC host.

@fabiofranzini
Copy link
Collaborator Author

Hi @AJIXuMuK, yes and thanks for the suggestion! The purpose is to create a reusable control and extend the common set of controls that come from Adaptive Cards.

@joaojmendes
Copy link
Collaborator

joaojmendes commented Jan 19, 2022 via email

@fabiofranzini
Copy link
Collaborator Author

Tomorrow I and @joaojmendes will synchronize and let's see how to collaborate on this component 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants