Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FilePicker] - the endPoint for webSearch do not work #1256

Closed
PooLP opened this issue Jul 7, 2022 · 3 comments · Fixed by #1262
Closed

[FilePicker] - the endPoint for webSearch do not work #1256

PooLP opened this issue Jul 7, 2022 · 3 comments · Fixed by #1262
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@PooLP
Copy link
Contributor

PooLP commented Jul 7, 2022

Category

[x ] Enhancement

[ ] Bug

[ ] Question

The endpoint on the current version do not work, replace actual code by (FilesSearchService.ts file / line 145) =>

// Submit the request
const apiUrl: string = `https://api.bing.microsoft.com/v7.0/images/search?q=${encodeURIComponent(query)}&count=${maxResults}&aspect=${aspect}&maxFileSize=${maxFileSize}&size=${size}&mkt=en-US&license=${license}`;

const searchDataResponse: HttpClientResponse = await this._httpClient.get(apiUrl, SPHttpClient.configurations.v1, {
  method: 'GET',
  mode: 'cors',
  headers: {
    'Ocp-Apim-Subscription-Key': binAPIKey,
  }
});
@ghost
Copy link

ghost commented Jul 7, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 7, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 7, 2022

@PooLP - please, feel free to submit a PR!

@PooLP
Copy link
Contributor Author

PooLP commented Jul 8, 2022

it's ok after configuration of my platfom to create a PR (I didn't haved this from replacement of my computer)

@PooLP PooLP closed this as completed Jul 8, 2022
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Jul 11, 2022
@AJIXuMuK AJIXuMuK added this to the 3.9.0 milestone Jul 11, 2022
@AJIXuMuK AJIXuMuK mentioned this issue Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants