Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People Picker returns no results on 3.10.0 #1292

Closed
c-eiser13 opened this issue Aug 24, 2022 · 23 comments
Closed

People Picker returns no results on 3.10.0 #1292

c-eiser13 opened this issue Aug 24, 2022 · 23 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@c-eiser13
Copy link
Contributor

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.10.0 ]

Expected / Desired Behavior / Question

Using tenant search in people picker should return results.

Observed Behavior

No results are returned and network error is observed.
image

I pulled the latest version of project and debugged and it looks like the issue is with this change:

peoplepicker3

I've reverted just those 3 changes back and the people picker is working properly again. I will create a PR with this change if it helps.

Steps to Reproduce

Add the people picker control to a page and do not add groupName or groupId params.

@ghost
Copy link

ghost commented Aug 24, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Aug 24, 2022
c-eiser13 added a commit to c-eiser13/sp-dev-fx-controls-react that referenced this issue Aug 24, 2022
@trueleader
Copy link

Same problem here

@HarminderSethi
Copy link
Contributor

I am also getting below error while using PeoplePicker control. Versions used - "@pnp/spfx-controls-react": "^3.10.0", "@fluentui/react": "^8.92.1", SPFx: 1.15.2
image

@c-eiser13
Copy link
Contributor Author

Created this PR that should address this issue #1293

@HarminderSethi
Copy link
Contributor

@c-eiser13 I am getting the same error even if I use version 3.5.0 for @pnp/spfx-controls-react with "@fluentui/react": "^8.92.1", SPFx: 1.15.2. Any temporary fix for this?

@c-eiser13
Copy link
Contributor Author

@HarminderSethi I'm using 3.9.0 and do not have these issues, also on SPFx 1.15.2

@HarminderSethi
Copy link
Contributor

@c-eiser13 this is my package.json

{
"name": "local-workflow",
"version": "0.0.1",
"private": true,
"main": "lib/index.js",
"scripts": {
"build": "gulp bundle",
"clean": "gulp clean",
"test": "gulp test",
"serve": "gulp bundle --custom-serve --max_old_space_size=4096 && fast-serve"
},
"dependencies": {
"@fluentui/react": "^8.93.0",
"@microsoft/sp-core-library": "1.15.2",
"@microsoft/sp-lodash-subset": "1.15.2",
"@microsoft/sp-office-ui-fabric-core": "1.15.2",
"@microsoft/sp-property-pane": "1.15.2",
"@microsoft/sp-webpart-base": "1.15.2",
"@pnp/sp": "^3.6.0",
"@pnp/spfx-controls-react": "^3.9.0",
"@xstate/react": "^3.0.1",
"camljs": "^2.13.0",
"moment": "^2.29.4",
"nunjucks": "^3.2.3",
"react": "16.13.1",
"react-dom": "16.13.1",
"tslib": "2.3.1",
"xstate": "^4.33.4"
},
"devDependencies": {
"@microsoft/rush-stack-compiler-4.5": "0.2.2",
"@rushstack/eslint-config": "2.5.1",
"@microsoft/eslint-plugin-spfx": "1.15.2",
"@microsoft/eslint-config-spfx": "1.15.2",
"@microsoft/sp-build-web": "1.15.2",
"@types/webpack-env": "~1.15.2",
"ajv": "^6.12.5",
"gulp": "4.0.2",
"typescript": "4.5.5",
"@types/react": "16.9.51",
"@types/react-dom": "16.9.8",
"eslint-plugin-react-hooks": "4.3.0",
"@microsoft/sp-module-interfaces": "1.15.2",
"spfx-fast-serve-helpers": "~1.15.0"
}
}

@HarminderSethi
Copy link
Contributor

@c-eiser13 Payload: image

response : {"error":{"code":"-1, Microsoft.OData.Core.ODataException","message":"A null value was found for the property named 'SharePointGroupID', which has the expected type 'Edm.Int32[Nullable=False]'. The expected type 'Edm.Int32[Nullable=False]' does not allow null values."}}

@trueleader
Copy link

you did not fixiate the version of spfx control.
Either:
"@pnp/spfx-controls-react": "3.9.0",

or skip the broken version (expecting 3.10.1 will be the next bugfix version fixing this bug):
"@pnp/spfx-controls-react": "^3.10.1 || 3.9.0",

@HarminderSethi
Copy link
Contributor

^ before the version was the issue. I did not notice this . Thanks for your help :)

@ekdegerman
Copy link

Any chance for a resolution to this one anytime soon? It would really help, since it is the first version in a long time that doesn't require casting the context as any and breaking the default ESLint rules (no-explicit-any) that came with SPFx 1.15. It also seems to resolve the strange issue described in #1235

@joelfmrodrigues
Copy link
Collaborator

@ekdegerman the PR from @c-eiser13 should be merged very soon

c-eiser13 added a commit to c-eiser13/sp-dev-fx-controls-react that referenced this issue Sep 8, 2022
@joelfmrodrigues
Copy link
Collaborator

The fix from @c-eiser13 is now on the dev branch and should be in the beta release within a few minutes. If anyone has the chance to test, please let us know if the issue persists.

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Sep 8, 2022
@joelfmrodrigues joelfmrodrigues added this to the 3.11.0 milestone Sep 8, 2022
@ekdegerman
Copy link

The fix from @c-eiser13 is now on the dev branch and should be in the beta release within a few minutes. If anyone has the chance to test, please let us know if the issue persists.

Works fine in my component with the beta version. Probably a pretty simple case, though, just using the people picker separately to allow picking people from all users inside a react function component. This version seems to resolve both issues I've experienced on earlier releases.

@vystartasv
Copy link

The fix from @c-eiser13 is now on the dev branch and should be in the beta release within a few minutes. If anyone has the chance to test, please let us know if the issue persists.

People Picker issue is fixed on beta release. You saved my day. Thanks a million @c-eiser13 and @joelfmrodrigues :)

@alexabramkin
Copy link

Fix in beta version works

@martinlingstuyl
Copy link
Contributor

Does anyone know when we can expect the release of 3.11?

I need a feature in 3.10 as well as the people picker fix 😁

Using the beta version is ok, but not great for production purposes.

@joelfmrodrigues
Copy link
Collaborator

Hi @martinlingstuyl
Maybe in a few days, if we can find the time to review pending PRs :)

@martinlingstuyl
Copy link
Contributor

Ok 👍
And introduce possible bugs by last minute PR merges? exciting! 😁

@ekdegerman
Copy link

I see that 3.11.0 is now available as a release here in Github, however npm still has 3.10.0 as the latest release. When can we expect 3.11.0 to be available there as well? It seemed instant for the beta release so I thought I'd ask if it is to be expected or something is wrong...

@Vertamin
Copy link
Contributor

Vertamin commented Oct 5, 2022

Yes please, Im craving for this update!

@joelfmrodrigues
Copy link
Collaborator

@ekdegerman thanks for the heads up, there seems to have been some issue with the action that publishes the release and we will look into it

@joelfmrodrigues
Copy link
Collaborator

3.11.0 is now available on npm. Please let us know if you find any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

9 participants