Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FolderPicker: get folders of other site url instead of the current context/site #1305

Closed
frankyvc opened this issue Sep 7, 2022 · 5 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@frankyvc
Copy link

frankyvc commented Sep 7, 2022

Hi team,

Category

[ ] Enhancement, Bug

Version

Please specify what version of the library you are using: [ "@pnp/spfx-controls-react": "3.10.0" ]

Expected / Desired Behavior / Question

When using the FolderPicker component, i need to be able to select a site url of another site collection (not the one i'm currently at).
With this site url i want to open the FolderPicker component.

Observed Behavior

The FolderPicker component always takes the this.props.context (current context and site).
When i check the code in the FolderPicker component, behind the scenes it calls the FolderExplorer and passes the current context.

Steps to Reproduce

Implement the FolderPicker and try to use this for another site, not the current site/context

Submission Guidelines

The FolderExplorer component CAN ACCEPT also a property 'siteAbsoluteUrl'.
To fix the issue, i think we only need to add a 'siteAbsoluteUrl' property to the FolderPicker component and pass the correct siteUrl behind the scenes to the FolderExplorer.

Thanks!

@ghost
Copy link

ghost commented Sep 7, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Thank you for submitting your first issue to this project.

@BlazeOfFeathers
Copy link

Any update about issue?

@NishkalankBezawada
Copy link
Contributor

Hello, I have opened a pull request and tested it (Please check the screenshots attached in the PR).

Fingers crossed.

//Nishkalank Bezawada

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Nov 4, 2022
@AJIXuMuK AJIXuMuK added this to the 3.12.0 milestone Nov 4, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Nov 4, 2022

Thanks to @NishkalankBezawada it will be fixed/improved in the next release.

AJIXuMuK pushed a commit that referenced this issue Nov 16, 2022
Fix folderpicker to get folders of other site instead of the current context by adding a new property siteAbsoluteUrl and forwarding it to FolderExplorer.
Fix #1305
@AJIXuMuK AJIXuMuK mentioned this issue Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

4 participants