Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add ViewPicker similar to SitePicker and ListPicker #1439

Closed
rzempo opened this issue Feb 5, 2023 · 11 comments · Fixed by #1709
Closed

Request to add ViewPicker similar to SitePicker and ListPicker #1439

rzempo opened this issue Feb 5, 2023 · 11 comments · Fixed by #1709
Labels
area:new-control status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@rzempo
Copy link

rzempo commented Feb 5, 2023

Category

[x] Enhancement
[ ] Bug
[ ] Question

Version

Please specify what version of the library you are using: [3.12.0]

Expected / Desired Behavior / Question

Use a controls to get the views from a list similar to SitePicker and ListPicker

Observed Behavior

A ViewPicker control doesn't currently exists

Thanks!

@ghost
Copy link

ghost commented Feb 5, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Thank you for submitting your first issue to this project.

@joelfmrodrigues
Copy link
Collaborator

@rzempo many thanks for the suggestion.
We do have a view picker control as part of the property controls repository, so perhaps it's not that complex to create a control here using that one as a reference plus the list picker.
Would you be interested in contributing and submitting a PR with the new control?

@joelfmrodrigues joelfmrodrigues added help wanted area:new-control type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Feb 27, 2023
@rzempo
Copy link
Author

rzempo commented Mar 10, 2023

@joelfmrodrigues, sure. It'll be my first time doing that. Can you please point me in the right direction?

@joelfmrodrigues
Copy link
Collaborator

joelfmrodrigues commented Mar 14, 2023

@rzempo really sorry for the delay, a lot of projects are ongoing at the moment at my end...
Try to start by following the docs and let us know if you get stuck or find any issues

https://pnp.github.io/sp-dev-fx-controls-react/guides/mpa/

If you never contributed to community repositories before and are looking for more information/suggestions on where to start, I recommend also having a look here: https://pnp.github.io/sharing-is-caring/
There are sessions you can join and ask any questions

@NishkalankBezawada
Copy link
Contributor

Hi @rzempo

Nice suggestion! If I find the time I'm definitely willing to make the controls above.

@joelfmrodrigues, I will be creating a PR in couple of days for this :)

Thanks!
Nishkalank

@NishkalankBezawada
Copy link
Contributor

Hey @joelfmrodrigues,

Greetings for the day. I have created a new PR 1505 for the above issue. Request you to please review.

Happy Easter in advance,
Nishkalank Bezawada

@joelfmrodrigues
Copy link
Collaborator

@NishkalankBezawada many thanks. Only seeing this now as I was off work and away from home with very limited internet access.
Will try to review as soon as possible

@NishkalankBezawada
Copy link
Contributor

@joelfmrodrigues Thanks for the reply, Once reviewed please let me know your comments and feedback :) May be change it according to your review

@NishkalankBezawada
Copy link
Contributor

NishkalankBezawada commented Apr 28, 2023

Hello @AJIXuMuK & @joelfmrodrigues , I had deleted the previous PR and created a new PR for this control since i could not find your comments for the PR. Kindly review and comment.

//Nishkalank

@joelfmrodrigues
Copy link
Collaborator

@rzempo the PR from @NishkalankBezawada was finally merged (sorry for the very long delay) and the control should be available on the beta release in a few minutes.
Many thanks for the suggestion

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed help wanted labels Sep 10, 2023
@joelfmrodrigues joelfmrodrigues added this to the 3.16.0 milestone Sep 10, 2023
@AJIXuMuK AJIXuMuK mentioned this issue Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:new-control status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants