Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker - recent tab empty until re-render #1482

Closed
c-eiser13 opened this issue Mar 3, 2023 · 2 comments
Closed

FilePicker - recent tab empty until re-render #1482

c-eiser13 opened this issue Mar 3, 2023 · 2 comments
Labels
Needs: Triage 🔍 status:fixed-next-drop Issue will be fixed in upcoming release.

Comments

@c-eiser13
Copy link
Contributor

c-eiser13 commented Mar 3, 2023

Category

[ ] Enhancement

[ x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.13.0 ]

Expected / Desired Behavior / Question

When the file picker opens and defaults to the recent tab, should show results.

Observed Behavior

When the file picker opens and defaults to the recent tab, nothing is shown until a re-render. I can resize the page, or navigate to a different tab, stock images for example, then back to Recent and content is shown correctly. Initial load:
image

After resizing the page and a re-render:
image

In debugging the project, looks like the issue is in the _getItemCountForPage method when trying to set the column width, the surfaceRect.width prop is 0, so the width is not set correctly until a re-render.
FilePickerNaNError

I've added some default values for columnCount and columnWidth when the surfaceRect.width is 0 and this solves the issue, I just do not work with the Fluent List control much so not sure this is the best solution.
image

I will create a PR with this change for review.

Steps to Reproduce

I was able to debug the project and repro by testing in the ControlsTest web part that is part of the project. Open the file picker when defaulting to the Recent tab and notice there are no results.

@ghost
Copy link

ghost commented Mar 3, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@joelfmrodrigues
Copy link
Collaborator

New release just published, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

3 participants