Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file picker recent tab wont render until page re-sized, adds def… #1483

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

c-eiser13
Copy link
Contributor

…ault values to avoid this issue.

Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1482

What's in this Pull Request?

This PR adds some default values for columnWidth and columnCount when the passed in surfaceRect.width is 0 to avoid the NaN issue that causes the recent tab to be blank on initial load.

See #1482 for more information on this issue.

@joaojmendes joaojmendes self-requested a review March 5, 2023 16:56
@joaojmendes joaojmendes added this to the 3.14.0 milestone Mar 5, 2023
@joaojmendes joaojmendes merged commit 2333be3 into pnp:dev Mar 5, 2023
@joaojmendes
Copy link
Collaborator

@c-eiser13 , Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants