Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I use a [sp-dev-fx-controls-react] for SP16 On-Premise #149

Closed
geogikk92 opened this issue Oct 8, 2018 · 3 comments
Closed

Can I use a [sp-dev-fx-controls-react] for SP16 On-Premise #149

geogikk92 opened this issue Oct 8, 2018 · 3 comments

Comments

@geogikk92
Copy link

geogikk92 commented Oct 8, 2018

Category

[ ] Enhancement
[ ] Bug
[x] Question

Can I use a [sp-dev-fx-controls-reac] for SP16 On-Premise ??

After install sp-dev-fx-controls-reac with npm install @pnp/spfx-controls-react --save --save-exact i have following errors:

untitled

This is content of my .yo-rc.json file is:

{ "@microsoft/generator-sharepoint": { "version": "1.4.0", "libraryName": "travels", "libraryId": "10340777-f8eb-4423-ba85-3fb5794a7bf1", "environment": "onprem" } }

@geogikk92 geogikk92 changed the title Can I use a [sp-dev-fx-controls-reac] for SP16 On-Premise Can I use a [sp-dev-fx-controls-react] for SP16 On-Premise Oct 8, 2018
@estruyf
Copy link
Member

estruyf commented Oct 10, 2018

@geogikk92 we recently set the minimal Office UI Fabric version to 5.120.0, this could have an impact on older project versions.

Could you test out version 1.7.0 by installing it as follows: npm i @pnp/spfx-controls-react@1.7.0 -S

@cameronsibbald
Copy link

I've been testing 1.7.0 with an on premise solution and have been able to get it to working.

I had to manually change the ControlStrings setting to ../node_modules/@pnp/spfx-controls-react/lib/loc/{locale}.js in order to get it to serve properly. I was receiving the following error until I changed it:

Error - 'collectLocalizedResources' sub task errored after 9.43 ms
 "Error for resource \"ControlStrings\": No localized files found under the \"lib\" directory matching pattern \"node_modules/@pnp/spfx-controls-react/lib/loc/{locale}.js\""

@AJIXuMuK
Copy link
Collaborator

Closing as answered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants