Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme documents highlight extension does not work correctly #1495

Closed
ValerasNarbutas opened this issue Mar 29, 2023 · 6 comments · Fixed by #1816
Closed

Readme documents highlight extension does not work correctly #1495

ValerasNarbutas opened this issue Mar 29, 2023 · 6 comments · Fixed by #1816
Assignees
Labels
area:documentation status:fixed-next-drop Issue will be fixed in upcoming release. status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:bug
Milestone

Comments

@ValerasNarbutas
Copy link
Contributor

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ ]
[Latest]
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Looks like were are breaking symbols in readme files under guides or contributing:
https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/

image

I can work on this one @joaojmendes
Just wondering is extension used does not support "sh " and should be "bash"

change this:

# comment

to this:

# comment

In all documents which using "#" for commenting.

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Mar 29, 2023
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@michaelmaillot
Copy link
Collaborator

Hi @ValerasNarbutas,

Are you still interested into submitting a PR? 🙂

@ValerasNarbutas
Copy link
Contributor Author

Hey, Sure @michaelmaillot, i can do it

@michaelmaillot michaelmaillot added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed help wanted labels Sep 14, 2023
@ValerasNarbutas
Copy link
Contributor Author

i did forget this one :)
i will check it soon

@ValerasNarbutas
Copy link
Contributor Author

@michaelmaillot added fixes.

AJIXuMuK added a commit that referenced this issue Feb 11, 2024
@AJIXuMuK AJIXuMuK added this to the 3.18.0 milestone Feb 11, 2024
@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation status:fixed-next-drop Issue will be fixed in upcoming release. status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants