Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TaxonomyPicker] Sometimes term path contains "termsetName" sometimes not in "onChange" event #1597

Closed
wuxiaojun514 opened this issue Jul 19, 2023 · 2 comments · Fixed by #1709
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@wuxiaojun514
Copy link
Contributor

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.14.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

The problem is at "onChange" event in TaxonomyPicker
In some scenario the path of term contains termset name while sometimes it doesn't have.

I think the term path should not have termset name.

Observed Behavior

If you choose term from panel, then its term path won't contain termset name
PickTermInPanel
However if you pick up term from the suggestion , then its path will start with termset name
PickerTermFromSuggestion
Also you will notice that the title of suggestion item contain double termset name

DoubleTermsetName

I debugged a bit on source code, terms from the suggestion are generated by convertSuggestTermToPickerTerm method which add full path.
image

Steps to Reproduce

You can follow https://pnp.github.io/sp-dev-fx-controls-react/controls/TaxonomyPicker/ to add TaxonomyPicker in webpart or extension to reproduce this issue

I can try to fix it.

Thanks!

@ghost
Copy link

ghost commented Jul 19, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 19, 2023
wuxiaojun514 pushed a commit to wuxiaojun514/sp-dev-fx-controls-react that referenced this issue Jul 20, 2023
@wuxiaojun514 wuxiaojun514 mentioned this issue Jul 20, 2023
@joelfmrodrigues joelfmrodrigues added this to the 3.16.0 milestone Sep 11, 2023
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Sep 11, 2023
@joelfmrodrigues
Copy link
Collaborator

Merged and will be part of the next release, many thanks @wuxiaojun514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants