-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListView select not working #251
Comments
I would suspect that using isEqual in componentDidUpdate might not behave in the expected way. If the select() function is bound in render(), as lodash does strict equality comparison on functions, it likely will always return false. |
Any update on this bug. It prevents anything beyond creating samples - no real world application for this control is possible beyond just displaying list data. |
If this PR goes through, that should fix this issue. |
Hi @thespooler, @jchilde The fix has been merged and will be included in the next release. In a meanwhile you can test the functionality in beta version. |
Fantastic! |
|
Category
Version
1.12.0
Expected / Desired Behavior / Question
When putting a ListView inside a React Component that controls its items and selection props, an item should be selectable.
Observed Behavior
When putting a ListView inside a React Component, anything that trigger componentDidUpdate, like setState or a prop change, will cause an invalidation of the items selection and cause an invalid call to props.selection().
Steps to Reproduce
Call setState on a component containing a ListView with a selected item and watch the selection disapear.
Handy reproduction: https://github.com/thespooler/listview-bughunt
The text was updated successfully, but these errors were encountered: