Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People Picker: starting the search after digiting n characters #374

Closed
gioce90 opened this issue Oct 4, 2019 · 4 comments · Fixed by #1709
Closed

People Picker: starting the search after digiting n characters #374

gioce90 opened this issue Oct 4, 2019 · 4 comments · Fixed by #1709
Assignees
Labels
Good First Issue 🏆 help wanted status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@gioce90
Copy link

gioce90 commented Oct 4, 2019

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.14.0 ]

Expected / Desired Behavior / Question

I noticed that the People Picker doesn't give the chance of choose the number of characters for starting the search. I know the related performance issues, but I think that is a bit limitating.

The responsable line code is:
https://github.com/SharePoint/sp-dev-fx-controls-react/blob/329cbc86051b306c072a741a721da8e2bcfc24dd/src/controls/peoplepicker/PeoplePickerComponent.tsx#L105

I think would be usefull to have a optional prop in IPeoplePickerProps for set this number.

Observed Behavior

The search starts only after have digit the third character. I think is limitating.

Thanks!

@ghost
Copy link

ghost commented Oct 4, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 4, 2019
@gioce90
Copy link
Author

gioce90 commented Nov 23, 2022

This issue is still in triage...?

@michaelmaillot michaelmaillot added help wanted Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Sep 5, 2023
@NishkalankBezawada
Copy link
Contributor

Hey @michaelmaillot,
I am working on this issue too, Could you assign this to me :)

Thanks,
Nishkalank

@joelfmrodrigues
Copy link
Collaborator

@gioce90 PR from @NishkalankBezawada was merged and the change is now in the beta release. If you have the chance to test, please let us know if this is now resolved

@joelfmrodrigues joelfmrodrigues added this to the 3.16.0 milestone Oct 25, 2023
@AJIXuMuK AJIXuMuK mentioned this issue Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue 🏆 help wanted status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants