Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue 374 - Added a new property to People Picker #1663

Merged
merged 2 commits into from Oct 25, 2023
Merged

Fixing Issue 374 - Added a new property to People Picker #1663

merged 2 commits into from Oct 25, 2023

Conversation

NishkalankBezawada
Copy link
Contributor

@NishkalankBezawada NishkalankBezawada commented Sep 29, 2023

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #374

What's in this Pull Request?

Fixing issue #374 - Added a new property to PeoplePicker, as 'SearchTextLimit'

Problem Statement

The search in the people picker only starts after a certain characters are entered.

Solution

Added a new property, which specifies the minimum character count needed to begin retrieving search results. Default is set to 2

New Property

  searchTextLimit?: number;

Control

<PeoplePicker
    context={this.props.context}
    titleText="People Picker"
    personSelectionLimit={3}
    groupName={"Team Site Owners"} 
    showtooltip={true}
    required={true}
    disabled={true}
    searchTextLimit={5} //New property, if this is not specified, default value is considered as 2
    onChange={this._getPeoplePickerItems}
    showHiddenInUI={false}
    principalTypes={[PrincipalType.User]}
    resolveDelay={1000} />

Screenshots

Untitled video (26) (1)

Thanks,
Nishkalank Bezawada

@NishkalankBezawada NishkalankBezawada changed the title Issue 374 Fixing Issue 374 - Added a new property to People Picker Sep 29, 2023
@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review September 30, 2023 22:27
@NishkalankBezawada
Copy link
Contributor Author

Hello @joelfmrodrigues could you please review this.

Thanks,
Nishkalank

@joelfmrodrigues joelfmrodrigues merged commit 3968c46 into pnp:dev Oct 25, 2023
1 check passed
@joelfmrodrigues joelfmrodrigues added this to the 3.16.0 milestone Oct 25, 2023
@joelfmrodrigues
Copy link
Collaborator

Many thanks @NishkalankBezawada !

@NishkalankBezawada NishkalankBezawada deleted the Issue-374 branch October 26, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants