Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in IconPicker doesn't work at all #512

Closed
valerydolyuk opened this issue Mar 25, 2020 · 4 comments
Closed

Search in IconPicker doesn't work at all #512

valerydolyuk opened this issue Mar 25, 2020 · 4 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone
1.18.0

Comments

@valerydolyuk
Copy link

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

[1.17.0]

Nothing happens when type text in search box.
Error in browser console: "IconPicker.js:52 Uncaught TypeError: Cannot read property 'length' of undefined"

Reason:
onChange handler expects 2 parameters (_event and newValue), but the method is called only with one parameter newValue.

Thanks!
@ghost
Copy link

ghost commented Mar 25, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Mar 25, 2020
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@gautamdsheth gautamdsheth mentioned this issue Mar 30, 2020
Merged
@MarianoPrz
Copy link

Same problem here, there is a PR pending i see...

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Apr 28, 2020
@AJIXuMuK AJIXuMuK added this to the 1.18.0 milestone Apr 28, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @valerydolyuk!
Thank you for reporting this bug!
The fix has been merged.
Could you please test it in beta version?

@AJIXuMuK AJIXuMuK mentioned this issue Apr 28, 2020
Closed
@estruyf estruyf mentioned this issue May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Milestone
1.18.0
Development

No branches or pull requests
3 participants
@valerydolyuk @MarianoPrz @AJIXuMuK