Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Control doesn't return display name or address details of locations #585

Closed
joeljeffery opened this issue Jun 14, 2020 · 2 comments
Closed
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@joeljeffery
Copy link
Contributor

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1..0.18]

Expected / Desired Behavior / Question

The Map control uses OpenStreetMap.org's nominatim web service to perform searches and get location data. This returns a display name and can return address details.

SharePoint "Location" fields could use this data - albeit in a slightly different format.

Let's return this data along with the coordinates.

Observed Behavior

Only coordinates are returned by the Map.

Steps to Reproduce

Build an SPFx web part, hook up the Map control. Try and use the returned data to make a suitable value for a SharePoint Location field. Observe you could really use more data if it's there.

Joel Jeffery
w:joelblogs.co.uk
t:@joelblogs

@ghost
Copy link

ghost commented Jun 14, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jun 14, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jul 7, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 7, 2020

Thank you @joeljeffery for submitting the idea and implementing it!

The changes have been merged and will be available in the next release.
In a meanwhile you can test in in beta version.

@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants