Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnp Taxonomy Picker onload validation #602

Closed
geltapatio opened this issue Jul 7, 2020 · 3 comments
Closed

Pnp Taxonomy Picker onload validation #602

geltapatio opened this issue Jul 7, 2020 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@geltapatio
Copy link
Contributor

geltapatio commented Jul 7, 2020

[x ] Bug

[v1.19.0]

Expected / Desired Behavior / Question

TaxonomyPicker will display an error if the term reference is not valid because it was removed from the term store.
Before the user tries to save a list item, the user has to remove the invalid term(s).

Observed Behavior

TaxonomyPicker does not display an error indicating that the term has already been deleted from the term store.
The user tries to save a list item, which contains a term field with invalid term ID. He does not realize that there is an error until he tries to save it.

Steps to Reproduce

The user edits a list item, which contains at least one term field.
The user selects a term with the TaxonomyPicker and saves it in a list item term field.
The selected term is removed from the term store
The user edits the same list item and saves it.
The user receives an error, indicating that term is not valid.

Current Version
The term "Ablauf1_2ToDelete" does not exist in term store
bild1_termnotexist_Nok

Thanks!
Luis Miguel Gamiz

@ghost
Copy link

ghost commented Jul 7, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 7, 2020
@geltapatio geltapatio changed the title Pnp Taxonomy Picker Pnp Taxonomy Picker onload validation Jul 7, 2020
@geltapatio
Copy link
Contributor Author

I already fixed it and created a pull request Pull Requestt

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Jul 12, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @geltapatio for reporting and fixing it.

The PR has been merged and will be available in the next release.

Please, test it in beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants