Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent UI Updates to SharePoint - WebPartTitle control too thin now #605

Closed
joshmcrty opened this issue Jul 8, 2020 · 11 comments
Closed
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@joshmcrty
Copy link

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.19.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!

The WebPartTitle control should match the default web part title typeface, including font family, size, and weight.

Observed Behavior

If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a
suggestion or asking a question delete this section.

In my tenant (on targeted release), the current WebPartTitle control no longer matches the default SharePoint web part titles because the font weight is set to 100 (see here). The June 2020 roadmap podcast mentioned that Fluent UI is rolling out to more areas of SharePoint, so web part titles appear bolder now.

I can provide a PR to update the font weight if needed.

Steps to Reproduce

If you are reporting an issue please describe the steps to reproduce the bug in sufficient detail to allow testing. If you are making
a suggestion or asking a question delete this section.

Create an SPFx web part using the PnP WebPartTitle control. The control styles will use the thin font treatment instead of the newer Fluent UI bolder style in a tenant that has the new Fluent UI styles rolled out to it.

@ghost
Copy link

ghost commented Jul 8, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 8, 2020
@sympmarc
Copy link

sympmarc commented Jul 8, 2020

Hi, @joshmcrty!

@clarktozer
Copy link

+1

4 similar comments
@tallday
Copy link

tallday commented Sep 8, 2020

+1

@anoopt
Copy link
Member

anoopt commented Sep 9, 2020

+1

@maximreynaud
Copy link

+1

@dburgstaller-1992
Copy link

+1

@AJIXuMuK
Copy link
Collaborator

Hi @joshmcrty,
Thank you for reporting this!

Sorry for the long delay - finally it has been fixed and will be included in the next release.

In a meanwhile you can test it in beta version

@jimmywim
Copy link

Just a quick one - do you know if the font-colour also now inverts when the Section background is set to the "darkest/fullest" slot? If not - I'll raise another issue to track that.

@joshmcrty
Copy link
Author

@jimmywim it does if you pass the themeVariant to it.

@jimmywim
Copy link

@joshmcrty Perfect, thanks - just need to ask the pnp modern search folks nicely if they can pass it through xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

9 participants