TaxonomyPicker: Include check for separator while filtering path of terms when anchorId is configured #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Id is used with TaxonomyPicker control.
|
Thanks @devangbhavsar89 - this is merged and will soon be available as a beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Bug fix related to anchorId configuration inside TaxonomyPicker control - When anchorId is used with TaxonomyPicker control, and if there exists any other term (that is not as a child of anchor term and it starts with same name as the anchor term name), then that term becomes available in the terms listing. It should not be listed because it is not a child term.
Bug Description
Say, we have hierarchy of terms in the term store as follows:
Now if we configure TaxonomyPicker control to use "Helsinki" as anchorId, then TaxonomyPicker control shows results as follows:
While picking term from hierarchy listing
While filtering terms via. type-in
If we check the hierarchy of terms inside the term store, then "Helsinki, Espoo, Vantaa" is not a child term of "Helsinki". So ideally, it should not be listed/populated inside our control.
This PR fixes above mentioned issue of TaxonomyPicker control.