Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listview 'selection' property incorrectly marked at optional #67

Closed
rmillener opened this issue Apr 20, 2018 · 1 comment
Closed

listview 'selection' property incorrectly marked at optional #67

rmillener opened this issue Apr 20, 2018 · 1 comment

Comments

@rmillener
Copy link

rmillener commented Apr 20, 2018

Category

[x] Bug

[x] Question

Version

[ 1.2.5 ]

Expected / Desired Behavior / Question

Selection prop is not required.

Observed Behaviour

We're updating the content of a listview based on a button click. The initial load is fine but the second time we set 'items' we get 'TypeError: Cannot read property 'setItems' of undefined'.

This looks to be caused by a dependency on 'selection' in ListView.componentDidUpdate. Adding a 'selection' property resolves the issue.

Steps to Reproduce

Create a list view without 'selection'
Set items on mount
Set items for a second time
An error is thrown

@rmillener
Copy link
Author

Apologies resolved in latest beta as per #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant