Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bundle size (FilePicker) #732

Closed
nbelyh opened this issue Nov 12, 2020 · 4 comments
Closed

Reduce bundle size (FilePicker) #732

nbelyh opened this issue Nov 12, 2020 · 4 comments
Assignees
@AJIXuMuK
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone
2.2.0

Comments

@nbelyh
Copy link
Contributor

nbelyh commented Nov 12, 2020 •
edited
Loading

Category

[ ] Enhancement

[ ] Bug

[x] Question

Version

Please specify what version of the library you are using: [ 2.10 ]

Expected / Desired Behavior / Question

How can I reduce the FilePicker footprint? Now it's bigger than whole @FluentUI for example (and any other library), actually it's size seems to be somehow ridiculous 😄 Is it really the case, and FilePicker is that big, or am I misinterpreting the results? Check out this picture (produced by webpack-bundle-analyzer).

image

Do you have any recommendations to optimize the bundle size?
@ghost
Copy link

ghost commented Nov 12, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 12, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @nbelyh for reporting it!
I will investigate if we can do some optimizations.

@AJIXuMuK AJIXuMuK added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed Needs: Triage 🔍 labels Nov 20, 2020
@AJIXuMuK AJIXuMuK self-assigned this Nov 20, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @nbelyh,
I've updated the imports for the FilePicker. And now it looks much better.
The final size of the web part bundle that uses FilePicker decreased from 1.9 MB to 853 KB.

You can test new build using beta version

@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Nov 21, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Nov 21, 2020
@nbelyh
Copy link
Contributor Author

nbelyh commented Nov 21, 2020

Sounds great. Will check it out 👍

@estruyf estruyf mentioned this issue Dec 3, 2020
Merged
@AJIXuMuK AJIXuMuK closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AJIXuMuK AJIXuMuK

Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@nbelyh @AJIXuMuK