Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy Picker Control - Onchange event behavior #761

Closed
mahinthan opened this issue Dec 11, 2020 · 5 comments
Closed

Taxonomy Picker Control - Onchange event behavior #761

mahinthan opened this issue Dec 11, 2020 · 5 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@mahinthan
Copy link

Category

[x ] Enhancement
[ ] Bug
[ x] Question

Version

Please specify what version of the library you are using: [ 1.20.0 ]

Question

I'm using taxonomy picker control. While selecting terms from the panel, onchange event fires only when I click on Save from the footer. Can it be configured to fire the onchange event as the user select the terms?

Observed Behavior

  • While I'm on panel, onchange event fires only when I click on save button from footer
  • When I'm not using the panel, but selecting terms by typing in the autocomplete control, onchange event fires for every term selection
  • I've used the termActions to display a label next to each term, so that user can click on that to select terms. It does fires the actionCallback event. Since, both custom action label and checkbox of terms are displayed, user may be confused, in which way to select the term. Because selecting via custom action label, fires the event, while the checkbox selection does not fire the event.
@ghost
Copy link

ghost commented Dec 11, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Dec 11, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @mahinthan,
Thank you for bringing this up!

I don't think onChange should fire when a user selects item in the panel. onChange fires when the values are changed in the picker. In the panel user can click Cancel instead of Save, and nothing will be changed in the picker in that case.

We can potentially add some additional handler like onPanelTermSelected or something.

@mahinthan
Copy link
Author

Hi @AJIXuMuK ,

Thank you for the quick update.

I'm using this taxonomy picker control as a filter control. It means, I'm having a PnP ListView control displayed. Instead of showing the default filter available from ListView control, we are showing the taxonomy control, so that users can use that control/taxonomy control panel to filter items displayed on the ListView.

@AJIXuMuK
Copy link
Collaborator

Hi @mahinthan,

I've added onPanelSelectionChange property to the control. You can use it to get items while user selecting them in the panel, before Click or Save is clicked.
The changes will be included in the next release.

In a meanwhile you can test the functionality in beta version

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Attention 👋 type:discussion labels Dec 27, 2020
@AJIXuMuK AJIXuMuK added this to the 2.4.0 milestone Dec 27, 2020
@mahinthan
Copy link
Author

Thanks @AJIXuMuK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants