Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New control : Animated dialog #815

Closed
1 of 3 tasks
anoopt opened this issue Mar 5, 2021 · 7 comments
Closed
1 of 3 tasks

New control : Animated dialog #815

anoopt opened this issue Mar 5, 2021 · 7 comments
Labels
type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@anoopt
Copy link
Member

anoopt commented Mar 5, 2021

Category

  • Enhancement
  • Bug
  • Question

Details

A new control called Animated dialog which is an enhanced version of Fabric UI react dialog.

The new control will be an extension of the Fabric UI dialog with some extra properties that will drive the animation i.e.

  • the way the dialog appears and hides
  • an extra icon above the title (with some animation)

Demo

Animated Dialog

@ghost
Copy link

ghost commented Mar 5, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Mar 5, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 5, 2021

Hi @anoopt,

I think it's an awesome enhancement!
Will you prep the PR?

@AJIXuMuK AJIXuMuK added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Mar 5, 2021
@anoopt
Copy link
Member Author

anoopt commented Mar 5, 2021

Sure Alex. Will do 👍

@AJIXuMuK AJIXuMuK added this to the 2.6.0 milestone Mar 6, 2021
@anoopt
Copy link
Member Author

anoopt commented Mar 13, 2021

Hi @AJIXuMuK - I installed the beta version of PnP SPFx controls to test this control and I get an error with the external css that is present in the code.

I have added require('../../../node_modules/animate.css/animate.min.css'); in the AnimatedDialog control and I thought this would get bundled as part of the package.

Am I missing something?

@AJIXuMuK
Copy link
Collaborator

Hi @anoopt,

Hmmm, yes, it should be bundled.
I'll take a closer look.

@AJIXuMuK
Copy link
Collaborator

Hey @anoopt - I got it fixed.
As we're developing a library, we need to reference items from node_modules not as relative ones, but as actual modules.

In case of animate.css - require('animate.css/animate.min.css')

@anoopt
Copy link
Member Author

anoopt commented Mar 15, 2021

Ah. Thank you Alex for explaining the details. Very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants