Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link in the RichText control does not work #875

Closed
1 of 3 tasks
cwparsons opened this issue Apr 15, 2021 · 3 comments
Closed
1 of 3 tasks

Adding a link in the RichText control does not work #875

cwparsons opened this issue Apr 15, 2021 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@cwparsons
Copy link
Contributor

cwparsons commented Apr 15, 2021

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [3.0.0]

Expected / Desired Behavior / Question

When using the RichText control, adding a link does not work. This is similar to another comment made on issue #795.

Observed Behavior

After clicking the Save button on the Insert link modal, a JavaScript error occurs:

quill.js
image

RichText.tsx
image

Steps to Reproduce

  1. Run npm run serve to open up the SPFx workbench.
  2. Add the test control.
  3. Find the (invisible) RichText control midway down the page.
  4. Click on the Insert link button.
  5. Add an address and text to display to the modal.
  6. Press save.
@ghost
Copy link

ghost commented Apr 15, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Apr 15, 2021
AJIXuMuK added a commit that referenced this issue Apr 17, 2021
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Apr 17, 2021
@AJIXuMuK
Copy link
Collaborator

Hi @cwparsons,

Thank you for reporting the issue. It has been fixed and will be included in the next release.

@AJIXuMuK AJIXuMuK added this to the 2.7.0 milestone Apr 17, 2021
AJIXuMuK added a commit that referenced this issue Apr 17, 2021
@joelfmrodrigues
Copy link
Collaborator

@cwparsons Closing this item as this should now be fixed as part of the last release. Please update to the latest release and open a new issue if you still experience problems.
Many thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

3 participants